[PATCH 2/7] wined3d: Make wined3d_device_context procedures thread safe.

Jan Sikorski jsikorski at codeweavers.com
Mon Oct 11 10:59:44 CDT 2021


> On 11 Oct 2021, at 17:40, Henri Verbeet <hverbeet at gmail.com> wrote:
> 
> On Thu, 7 Oct 2021 at 13:06, Jan Sikorski <jsikorski at codeweavers.com> wrote:
>> ---
>> dlls/wined3d/cs.c     |  13 +++++
>> dlls/wined3d/device.c | 123 +++++++++++++++++++++++++++++++++++-------
>> 2 files changed, 118 insertions(+), 18 deletions(-)
>> 
> This patch is fine, although the subject line seems slightly
> misleading. This takes care of setters and draws, etc., but not for
> example wined3d_device_context_get_index_buffer().

Hm, it is, though I'm not sure how to improve it much. (make _some_ procedures?) Maybe add a second line saying that getters remain externally synchronized for now. That was mostly to avoid exporting per context locks in the last patch, or moving array getter loops into wined3d, in this series.

- Jan


More information about the wine-devel mailing list