[PATCH 2/7] wined3d: Make wined3d_device_context procedures thread safe.

Henri Verbeet hverbeet at gmail.com
Mon Oct 11 11:08:10 CDT 2021


On Mon, 11 Oct 2021 at 17:59, Jan Sikorski <jsikorski at codeweavers.com> wrote:
> > On 11 Oct 2021, at 17:40, Henri Verbeet <hverbeet at gmail.com> wrote:
> > This patch is fine, although the subject line seems slightly
> > misleading. This takes care of setters and draws, etc., but not for
> > example wined3d_device_context_get_index_buffer().
>
> Hm, it is, though I'm not sure how to improve it much. (make _some_ procedures?) Maybe add a second line saying that getters remain externally synchronized for now. That was mostly to avoid exporting per context locks in the last patch, or moving array getter loops into wined3d, in this series.
>
Personally, I probably would have split the patch and done e.g. just
setters in the first one. Adding a short note in the commit message
also works. It's probably not worth worrying too much about though.



More information about the wine-devel mailing list