[PATCH 4/4] joy.cpl: Better handle effect creation errors.
Rémi Bernon
rbernon at codeweavers.com
Thu Oct 14 02:39:55 CDT 2021
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51873
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
dlls/joy.cpl/main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/dlls/joy.cpl/main.c b/dlls/joy.cpl/main.c
index 4431669eee8..c96efb17aa3 100644
--- a/dlls/joy.cpl/main.c
+++ b/dlls/joy.cpl/main.c
@@ -867,6 +867,11 @@ static BOOL CALLBACK ff_effects_callback(const DIEFFECTINFOW *pdei, void *pvRef)
hr = IDirectInputDevice2_CreateEffect(
joystick->device, &pdei->guid, &dieffect, &joystick->effects[joystick->cur_effect].effect, NULL);
+ if (FAILED(hr))
+ {
+ FIXME("Failed to create effect with type %s, hr %#x\n", debugstr_guid(&pdei->guid), hr);
+ return DIENUM_CONTINUE;
+ }
joystick->effects[joystick->cur_effect].params = dieffect;
joystick->effects[joystick->cur_effect].info = *pdei;
--
2.33.0
More information about the wine-devel
mailing list