[PATCH v2 02/21] dlls/kernelbase: Use FIXME_ONCE

David Kahurani k.kahurani at gmail.com
Mon Oct 18 07:58:01 CDT 2021


introduce FIXME_ONCE

Signed-off-by: David Kahurani <k.kahurani at gmail.com>
---
 dlls/kernelbase/locale.c  | 10 ++++------
 dlls/kernelbase/main.c    |  5 +----
 dlls/kernelbase/process.c |  3 +--
 dlls/kernelbase/sync.c    |  3 +--
 dlls/kernelbase/thread.c  |  3 +--
 5 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/dlls/kernelbase/locale.c b/dlls/kernelbase/locale.c
index 1c2f4dd..f1ceaa4 100644
--- a/dlls/kernelbase/locale.c
+++ b/dlls/kernelbase/locale.c
@@ -3061,7 +3061,6 @@ INT WINAPI CompareStringEx( const WCHAR *locale, DWORD flags, const WCHAR *str1,
                            SORT_DIGITSASNUMBERS | 0x10000000;
     /* 0x10000000 is related to diacritics in Arabic, Japanese, and Hebrew */
     INT ret;
-    static int once;
 
     if (version) FIXME( "unexpected version parameter\n" );
     if (reserved) FIXME( "unexpected reserved value\n" );
@@ -3081,7 +3080,7 @@ INT WINAPI CompareStringEx( const WCHAR *locale, DWORD flags, const WCHAR *str1,
 
     if (flags & semistub_flags)
     {
-        if (!once++) FIXME( "semi-stub behavior for flag(s) 0x%x\n", flags & semistub_flags );
+        FIXME_ONCE( "semi-stub behavior for flag(s) 0x%x\n", flags & semistub_flags );
     }
 
     if (len1 < 0) len1 = lstrlenW(str1);
@@ -5237,8 +5236,8 @@ DWORD WINAPI DECLSPEC_HOTPATCH IsValidNLSVersion( NLS_FUNCTION func, const WCHAR
  */
 INT WINAPI DECLSPEC_HOTPATCH LCIDToLocaleName( LCID lcid, WCHAR *name, INT count, DWORD flags )
 {
-    static int once;
-    if (flags && !once++) FIXME( "unsupported flags %x\n", flags );
+    if (flags)
+	FIXME_ONCE( "unsupported flags %x\n", flags );
 
     return GetLocaleInfoW( lcid, LOCALE_SNAME | LOCALE_NOUSEROVERRIDE, name, count );
 }
@@ -5259,8 +5258,7 @@ INT WINAPI DECLSPEC_HOTPATCH LCMapStringEx( const WCHAR *locale, DWORD flags, co
     if (reserved) FIXME( "unsupported reserved pointer %p\n", reserved );
     if (handle)
     {
-        static int once;
-        if (!once++) FIXME( "unsupported lparam %lx\n", handle );
+        FIXME_ONCE( "unsupported lparam %lx\n", handle );
     }
 
     if (!src || !srclen || dstlen < 0)
diff --git a/dlls/kernelbase/main.c b/dlls/kernelbase/main.c
index b90ee1c..c032b31 100644
--- a/dlls/kernelbase/main.c
+++ b/dlls/kernelbase/main.c
@@ -219,10 +219,7 @@ BOOL WINAPI QuirkIsEnabled(void *arg)
  */
 BOOL WINAPI QuirkIsEnabled3(void *unk1, void *unk2)
 {
-    static int once;
-
-    if (!once++)
-        FIXME("(%p, %p) stub!\n", unk1, unk2);
+    FIXME_ONCE("(%p, %p) stub!\n", unk1, unk2);
 
     return FALSE;
 }
diff --git a/dlls/kernelbase/process.c b/dlls/kernelbase/process.c
index 5973eb7..35829b5 100644
--- a/dlls/kernelbase/process.c
+++ b/dlls/kernelbase/process.c
@@ -1046,8 +1046,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH ProcessIdToSessionId( DWORD pid, DWORD *id )
  */
 BOOL WINAPI DECLSPEC_HOTPATCH QueryProcessCycleTime( HANDLE process, ULONG64 *cycle )
 {
-    static int once;
-    if (!once++) FIXME( "(%p,%p): stub!\n", process, cycle );
+    FIXME_ONCE( "(%p,%p): stub!\n", process, cycle );
     SetLastError( ERROR_CALL_NOT_IMPLEMENTED );
     return FALSE;
 }
diff --git a/dlls/kernelbase/sync.c b/dlls/kernelbase/sync.c
index ab963c6..73af62f 100644
--- a/dlls/kernelbase/sync.c
+++ b/dlls/kernelbase/sync.c
@@ -777,8 +777,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH SetWaitableTimerEx( HANDLE handle, const LARGE_INT
                                                   PTIMERAPCROUTINE callback, LPVOID arg,
                                                   REASON_CONTEXT *context, ULONG tolerabledelay )
 {
-    static int once;
-    if (!once++) FIXME( "(%p, %p, %d, %p, %p, %p, %d) semi-stub\n",
+    FIXME_ONCE( "(%p, %p, %d, %p, %p, %p, %d) semi-stub\n",
                         handle, when, period, callback, arg, context, tolerabledelay );
 
     return SetWaitableTimer( handle, when, period, callback, arg, FALSE );
diff --git a/dlls/kernelbase/thread.c b/dlls/kernelbase/thread.c
index 9b97c4a..dd59036 100644
--- a/dlls/kernelbase/thread.c
+++ b/dlls/kernelbase/thread.c
@@ -384,8 +384,7 @@ DWORD WINAPI DECLSPEC_HOTPATCH QueueUserAPC( PAPCFUNC func, HANDLE thread, ULONG
  */
 BOOL WINAPI DECLSPEC_HOTPATCH QueryThreadCycleTime( HANDLE thread, ULONG64 *cycle )
 {
-    static int once;
-    if (!once++) FIXME( "(%p,%p): stub!\n", thread, cycle );
+    FIXME_ONCE( "(%p,%p): stub!\n", thread, cycle );
     SetLastError( ERROR_CALL_NOT_IMPLEMENTED );
     return FALSE;
 }
-- 
2.33.0




More information about the wine-devel mailing list