[PATCH v2 01/21] include/wine: suppress subsequent FIXMEs into WARNINGs

[David Kahurani]

On Mon, Oct 18, 2021 at 4:12 PM Sven Baars <sven.wine at gmail.com> wrote:

> On 18-10-2021 14:58, David Kahurani wrote:
> >
> > +#define __WINE_DPRINTF_ONCE(dbcl,dbc2,dbch) \
> > +    static BOOL __wine_next_time_level;\
> > +    const enum __wine_debug_class __dbcl = \
> > +    __wine_next_time_level ? __WINE_DBCL##dbc2 : __WINE_DBCL##dbc1;\
> > +    (!__WINE_GET_DEBUGGING(dbcl,(dbch)) || \
> > +     (wine_dbg_log(__dbcl,(dbch),__FILE__,"%d: ",__LINE__) == -1)) ? \
> > +     (void)0 : (void)wine_dbg_printf \
> > +     __wine_next_time_level = TRUE;
> > +
> Hi David,
>

Hello,


> I don't think this will work. First because variables should be declared
> at the beginning of a scope, and second because if there are two
> FIXME_ONCE in one scope __dbcl and __wine_next_time_level will be
> declared twice.
>

Should binding this into a do { } while (0) loop be enough? It looks like
it should to me.


> I didn't check the rest of the patch, but this stood out to me.
>
> Also, Chip asked you to not send so many patches at once. Please first
> try to get only this patch and one of the other patches in.
>

Well, he said in the future so my assumption was that it did not affect
this patchset probably because these patches are easy enough. All the
subsequent patches can be bundled into one, considered that but then again
they go into different subsystems. Okay, only two patches will be sent next
time.


> Sven
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211018/288fc269/attachment.htm>