[PATCH 5/6] user32: Use a DISPLAY_DEVICEW array as display device cache.
Rémi Bernon
rbernon at codeweavers.com
Thu Oct 28 02:50:47 CDT 2021
On 10/18/21 3:20 PM, Marvin wrote:
> Hi,
>
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=100336
>
> Your paranoid android.
>
>
> === debiant2 (32 bit report) ===
>
> user32:
> win.c:10420: Test failed: Expected foreground window 00120126, got 00AD00EA
>
> === debiant2 (64 bit WoW report) ===
>
> user32:
> menu.c:2337: Test failed: test 25
>
I don't think these are new failures introduced by the changes.
Then should I do something differently? I agree that using the cache for
some initial data is not exactly the best way to do it but adding the
code to initialize a list of devices in setupapi will either:
* duplicate code that's already duplicated in winex11.drv and winemac.drv,
* or we'll have to deduplicate these two first and as far as I could try
it's really not going to be easy.
--
Rémi Bernon <rbernon at codeweavers.com>
More information about the wine-devel
mailing list