[PATCH 5/6] user32: Use a DISPLAY_DEVICEW array as display device cache.

Francois Gouget fgouget at codeweavers.com
Thu Oct 28 14:23:32 CDT 2021


On Thu, 28 Oct 2021, Rémi Bernon wrote:
[...]
> > === debiant2 (32 bit report) ===
> > 
> > user32:
> > win.c:10420: Test failed: Expected foreground window 00120126, got 00AD00EA

This one is probably not detected as a preexisting failure because the 
window handle is different with every run (see e.g. the win32 Sep 9 and 
15 failures).

https://test.winehq.org/data/patterns.html#user32:win


> > === debiant2 (64 bit WoW report) ===
> > 
> > user32:
> > menu.c:2337: Test failed: test 25

And this one is because this test rarely fails and the last time it 
happened it was for entry 27 and not 25 (see the wow64 result of Sep 8). 
It's likely that both failures are timing issues.

https://test.winehq.org/data/patterns.html#user32:menu

So only two things can stop such false positives :
* Fixing the test somehow. I cannot really help with that.
* Or implementing a fix for the "always new" issue (bug 48209).
  I'm hoping to work on it once I'm done with what's currently on my 
  plate.


-- 
Francois Gouget <fgouget at codeweavers.com>


More information about the wine-devel mailing list