[PATCH 0/3] MR332: d3dx10: Support creating effect from pre-built shader
Matteo Bruni (@Mystral)
wine at gitlab.winehq.org
Fri Jul 1 14:25:12 CDT 2022
Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
> + ULONG refcount;
> + HRESULT hr;
> +
> + if (!(device = create_device()))
> + {
> + skip("Failed to create device, skipping tests.\n");
> + return;
> + }
> +
> + /* test creating effect from pre-built DXBC shader */
> + load_resource(GetModuleHandleA(NULL), L"fx_test_ecbt.fx", &fx_test_ecbt, &fx_test_ecbt_size);
> +
> + errors = NULL;
> + effect = NULL;
> + hr = D3DX10CreateEffectFromMemory(fx_test_ecbt, fx_test_ecbt_size, NULL,
> + NULL, NULL, "fx_4_0", 0x0, 0x0, device, NULL, NULL, &effect,
We usually use 0 (or NULL) in these cases, rather than 0x0, '\0' and such.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/332#note_3147
More information about the wine-devel
mailing list