Gerald Pfeifer <gerald(a)pfeifer.com> writes:
> So, I admit I don't really know this code, but looking at it (triggered
> by a warning issued by GCC development versions), I noticed that this
> variable passed by reference is not initialized here.
It's initialized when we return a type, and it doesn't need to be
initialized on NULL return. The code is correct, but you could probably
set the variable to NULL in the caller to silence the warning.
--
Alexandre Julliard
julliard(a)winehq.org
Looking at
RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector )
{
RPC_STATUS status;
ULONG c;
TRACE("(%p)\n", BindingVector);
for (c=0; c<(*BindingVector)->Count; c++) {
status = RpcBindingFree(&(*BindingVector)->BindingH[c]);
}
HeapFree(GetProcessHeap(), 0, *BindingVector);
*BindingVector = NULL;
return RPC_S_OK;
}
we currently always ignore the outcome of RpcBindingFree and return
RPC_S_OK.
However, there is one case where RpcBindingFree returns something
different (which is if *Binding is null when RPC_S_INVALID_BINDING
is returned).
What is the proper way of handling this? Just keeping the code as
is and removing the unused status variable? Breaking the loop once
RpcBindingFree returns something different from RPC_S_OK? Continuing
and returning the first / the last status different from RPC_S_OK?
Gerald
I?d like to volunteer to host WineConf 2019 in Toronto, Canada.
Toronto is the largest city in Canada and sits on the coast of Lake
Ontario (14th largest lake in the world). We have plenty of bars and
yes, lots of good beer. :-) What else do you need?
I?ve looked into venues and the most economical room rates are the
weekend of Oct 12-13. That?s around $189 CAD + Tax. For about 20% more
we can hold it in mid or late August. While the weather in August is
much nicer, October should still be pleasant. (~10-15 C)
Thanks,
-Ulrich
On 2019-02-27, 8:18 AM, "wine-devel on behalf of Alexandre Julliard"
<wine-devel-bounces(a)winehq.org on behalf of julliard(a)winehq.org> wrote:
Folks,
It's time to start thinking about this year's Wine conference!
Until now, selecting the next WineConf was a more or less ad-hoc
process, but we had some discussions on the wineconf list a while ago,
and it was suggested that the Wine Committee should play a more active
role in the decision, especially since the chosen location impacts the
financial decisions.
Ideally we'd define a formal set of requirements, and issue a Call for
Proposals, but it was felt that this would take too much time and thus
would be more appropriate for 2020. So I thought that for this year we'd
do a simple call for volunteers, and have the Wine Committee work with
the volunteers to select the best proposal.
So, would anybody like to volunteer to host WineConf 2019?
--
Alexandre Julliard
julliard(a)winehq.org