"Andrew Riedi" <andrewriedi(a)gmail.com> wrote:
> +static int test_ImmSetCompositionString(void)
It's a usual practice to have the test cases return 'void',
especially if you don't use the return value.
> +{
> + HIMC imc;
> + BOOL ret;
> + DWORD error;
> +
> + imc = ImmGetContext(hwnd);
First thing to test is the return value of ImmGetContext() and report
last error in the case of a failure.
--
Dmitry.
On Thu, 2008-11-27 at 01:30 +0100, Stefan Dösinger wrote:
>
> +
> + /* Note: Microsoft's d3d9.h does not declare
> IDirect3D9Ex::RegisterSoftwareDevice . This would mean that
> + * the offsets of the other methods in the Vtable change too.
> This, however, seems wrong. In Microsoft's
> + * d3d9.dll, the offsets for the other functions are still
> compatible with IDirect3D9.
> + * (This is probably because even in MS's header IDirect3D9Ex
> inherits from IDirect3D9, which makes the
> + * C++ inferface compatible, and nobody uses the C interface in
> Windows world
> + */
Maybe this should be documented via Wine's API doc "BUGS: " declaration
as well: http://www.winehq.org/site/docs/winedev-guide/api-docs
Looks great so far. Comments:
1) nested scrollbars are evil. Better to put the news on its own tab,
lose the little sidebar the news was in,
and have a very small area in the main box for just the one most
important headline.
2) The main choice text needs to be closer to user tasks. So instead of
Information
Overview of Wine features.
we should have
About
What is Wine, and why should I use it?
and we're missing the user task
Will my app work with Wine?
which should link to the appdb.
Thanks for taking care of this, Francois.
On Nov 23, 2008, at 5:15 PM, Francois Gouget wrote:
> Astute readers will notice that this leaves one loophole: nasty macro
> use like in dlls/winmm/message16.c:
>
> #define A(_x,_y) MMDRV_InstallMap(_x, \
> MMDRV_##_y##_Map16To32W, MMDRV_##_y##_UnMap16To32W, \
> MMDRV_##_y##_Map32WTo16, MMDRV_##_y##_UnMap32WTo16, \
> MMDRV_##_y##_Callback)
> A(MMDRV_AUX, Aux);
>
> A grep would not find that MMDRV_Aux_Callback is referenced by the
> above
> code.
Could you perhaps grep the output from the preprocessor, instead?
-Ken
Dan Kegel wrote:
> Thanks to Mike Hearn for pointing out that mshtml reference
> counting was wrong, and Jacek for pointing out how to fix
> it for now.
>
> Once gecko is loaded, don't let mshtml unload.
> This fixes a crash in starting Sketchup (bug 16164),
> and probably fixes a number of other apps that
> went pear-shaped after unloading mshtml...
>
>
> ------------------------------------------------------------------------
>
>
C++ style comment? Was this a Patchwatcher test ;)
--
Cheers,
Paul.
This is my first patch. It allows icons to be loaded as cursors because
it defaults hotspots to x = 0 and y = 0 if the hotspot isn't found.
Pasting patch into body of message. This is against the latest git .
--------------------------------------------------------------------------------------------------------------------------
--- cursoricon.c.orig 2008-11-23 15:07:32.000000000 -0600
+++ cursoricon.c 2008-11-23 15:13:22.000000000 -0600
@@ -932,7 +932,10 @@ static HICON CURSORICON_LoadFromFile( LP
entry = CURSORICON_FindBestIconFile( dir, width, height, colors );
if ( !entry )
- goto end;
+ /* this is my change. If there is no hotspot, default to 0, 0. */
+ hotspot.x = 0;
+ hotspot.y = 0;
+ goto iconskip;
/* check that we don't run off the end of the file */
if ( entry->dwDIBOffset > filesize )
@@ -942,6 +945,7 @@ static HICON CURSORICON_LoadFromFile( LP
hotspot.x = entry->xHotspot;
hotspot.y = entry->yHotspot;
+iconskip:
hIcon = CURSORICON_CreateIconFromBMI( (BITMAPINFO
*)&bits[entry->dwDIBOffset],
hotspot, !fCursor, 0x00030000,
width, height, loadflags );
--------------------------------------------------------------------------------------------------------------------------
Please look over the code.
Krzys D.
Dan Kegel wrote:
> This prevents http://bugs.winehq.org/show_bug.cgi?id=16164
>
> ( http://www.microsoft.com/msj/0197/activex/activex0197.aspx looks
> like a nice, scary article on the subject. )
>
- return module_ref ? S_FALSE : S_OK;
+ /* Some apps crash if we let mshtml be unloaded.
+ * Until we figure out why, don't let mshtml be unloaded.
+ */
+ return S_FALSE; /* module_ref ? S_FALSE : S_OK; */
I think we should prevent unloading mshtml.dll if Gecko was loaded. To
do it I'd suggest to increase module count in load_gecko function (it
will never be decreased so DLL won't be unloaded).
Jacek