Hello Marko,
thank you for your patch and welcome to Wine development.
While in general patches to make Wine use proper types are accepted
there is a slight problem with this patch.
On 06/01/2010 11:42 PM, grkoma(a)gmail.com wrote:
> From: Marko Nikolic<grkoma(a)gmail.com>
>
> ---
> libs/wine/config.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libs/wine/config.c b/libs/wine/config.c
> index 6bb87b0..c04b704 100644
> --- a/libs/wine/config.c
> +++ b/libs/wine/config.c
> @@ -146,10 +146,10 @@ static char *get_runtime_bindir( const char *argv0 )
> #ifdef linux
> for (size = 256; ; size *= 2)
> {
> - int ret;
> + ssize_t ret;
> if (!(bindir = malloc( size ))) break;
> if ((ret = readlink( "/proc/self/exe", bindir, size )) == -1) break;
> - if (ret != size)
> + if ((size_t)ret != size) /* Safe to cast, ret is> 0 here */
Having to use a cast to silence a -Wsign-compare is worse than keeping
the warning; especially as that is an extra warning not included in the
-Wall used by Wine. Though in this specific case by using the proper
types the warning can be eliminated without resorting to casts.
> {
> if (!(p = memrchr( bindir, '/', ret ))) break;
> if (p == bindir) p++;
bye
michael
Hi Łukasz
On 06/03/2010 11:51 AM, Łukasz Wojniłowicz wrote:
> ---
> dlls/mshtml/Pl.rc | 18 +-
> dlls/setupapi/Pl.rc | 23 +
> dlls/shell32/shell32_Pl.rc | 25 +-
> dlls/wininet/wininet_Pl.rc | 25 +-
> programs/notepad/Pl.rc | 21 +-
> programs/reg/Pl.rc | 6 +
> programs/regedit/Pl.rc | 14 +-
> programs/taskmgr/Pl.rc | 1063 ++++++++++++++++++++-----------------
> programs/wineboot/wineboot_Pl.rc | 11 +
> programs/winecfg/Pl.rc | 35 +-
> programs/winhlp32/Pl.rc | 29 +-
> programs/wordpad/Pl.rc | 40 +-
> 12 files changed, 762 insertions(+), 548 deletions(-)
I think it's better to send separate patches (so 1 per module) although
I must admit I don't have such an issue with this as they are
translations. Nonetheless it could be worthwhile resending them to
potentially avoid any delay once AJ comes back (and maybe he wants them
to be split).
> mode change 100644 => 100755 programs/taskmgr/Pl.rc
>
You have to resend anyway because this change is not needed.
Thanks for helping the Polish translation get to 100% !!
--
Cheers,
Paul.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=2444
Your paranoid android.
=== W7PROX64 (64 bit security) ===
security.c:922: Test failed: Access and/or AccessStatus were changed!
security.c:939: Test failed: Access and/or AccessStatus were changed!
security.c:950: Test failed: Access and/or AccessStatus were changed!
security.c:961: Test failed: Access and/or AccessStatus were changed!
security.c:972: Test failed: Access and/or AccessStatus were changed!
security.c:994: Test failed: Access and/or AccessStatus were changed!
security.c:1009: Test failed: Access and/or AccessStatus were changed!
security.c:1022: Test failed: Access and/or AccessStatus were changed!
security.c:1035: Test failed: Access and/or AccessStatus were changed!
Hi,
I'm trying to fix bug 18071 but I don't know anything about ACLs.
I wrote some tests (see attached patch and
https://testbot.winehq.org/JobDetails.pl?Key=2442)
and I modified the source according to my understanding of the issue
(wich may be totally wrong).
But as I'm not familiar with ACLs and because my changes are quite
important, I'm sending here my patches hoping a advapi32 coder could
have a look at it.
Thanks in advance
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=2443
Your paranoid android.
=== W98SE (32 bit db) ===
Failure running script in VM: Exceeded timeout limit of 315 sec
=== WNT4WSSP6 (32 bit db) ===
Timeout
On Thu, 2010-06-03 at 03:01 -0500, Andrew Nguyen wrote:
> This pleases the Actel Libero IDE installer.
> ---
> dlls/msi/version.rc | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
I think we should delay this until 1.2 is released because it
may trigger some installers to use unimplemented functionality
in msi.
Folks,
The weekly rc schedule won't be quite weekly this week, I'll be out for
the next few days so there won't be a release this Friday. The weekly
schedule will resume with rc3 next Friday. Don't let that stop you,
there are still enough regressions for everybody...
--
Alexandre Julliard
julliard(a)winehq.org
I am trying to get folding at home gpu client working. The issue we are
having now is that it detects the driver version and says it is not right,
and it won't proceed. I've searched through the lines of a WINEDEBUG=+trace
and I think the issue is:
0009:trace:d3d:init_driver_info OS version 5.1.
0009:trace:d3d_caps:init_driver_info Found card 10de:05e2 in driver DB.
0009:trace:d3d_caps:init_driver_info Reporting (fake) driver version
0x0006000f-0x000b21aa.
It could also be from:
0009:trace:reg:NtSetValueKey (0x14,L"Driver",1,0xff883b94,20)
0009: set_key_value( hkey=0014, type=1, namelen=12, name=L"Driver",
data={57,00,49,00,4e,00,45,00,20,00,53,00,43,00,53,00,49,00,00,00} )
But I think that is just trying to set a registry key, not get a registry
key (i.e. the driver version from the registry).
What I can't figure out is what version this is reporting. I've searched but
I can't find this driver DB, so I don't know what 0x0006000f-0x000b21aa
corespondent too. Can someone point me in the right directions?
Thanks,
Seth Shelnutt