On 3 July 2010 23:59, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> + ok(broken(TRUE), "U and V channels swapped on Non-Windows driver\n");
> + skip("Windows driver confuses U and V channels, skipping test\n");
You should use win_skip().
Tuomo Mattila <tuomom(a)ee.oulu.fi> wrote:
> +BOOL WINAPI GetVolumePathNamesForVolumeNameA(LPCSTR volumename, LPSTR volumepathname, DWORD buflen, PDWORD returnlen)
> +{
> +
> + BOOL ret = FALSE;
> + WCHAR* volumenameW = 0;
> + LPWSTR volumepathnameW = 0;
> +
> + if (volumename == 0 || volumepathname == 0 || returnlen == 0)
> + {
> + SetLastError(RPC_X_NULL_REF_POINTER);
> + return FALSE;
> + }
It's a common practice to use NULL for pointers, and not 0. Something tells
me that RPC_xxxx error code has nothing to do here, do you have a test case
for that?
> + memset(volumepathname, 0, buflen);
Is there any reason that you zero out the whole 'volumepathname' here?
> + volumepathnameW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, buflen*sizeof(WCHAR));
> + if (volumepathnameW == 0) return FALSE;
Same for 'volumepathnameW' here.
> + if ((volumenameW = FILE_name_AtoW(volumename, TRUE)) == 0) return FALSE;
> +
> + ret = GetVolumePathNamesForVolumeNameW(volumenameW, volumepathnameW, buflen, returnlen);
> + if (*returnlen > 0)
> + FILE_name_WtoA(volumepathnameW, (*returnlen), volumepathname, (*returnlen));
There is no need to put '*returnlen' in braces. Besides, '*returnlen' may
differ for multibyte and unicode strings.
--
Dmitry.
André Hentschel <nerv(a)dawncrow.de> wrote:
> --- a/libs/wine/sortkey.c
> +++ b/libs/wine/sortkey.c
> @@ -19,7 +19,6 @@
> */
> #include "wine/unicode.h"
>
> -extern int get_decomposition(WCHAR src, WCHAR *dst, unsigned int dstlen);
> extern const unsigned int collation_table[];
There is a commented out reference to get_decomposition() in that file, so
you need to remove it as well. But better make it used, and figure out why
it was commented out in the first place.
--
Dmitry.
http://wiki.winehq.org/FAQ#head-d3f53179ea4e0d7c90cf330e50030b1e14b63811
10.3. Nautilus can delete your home directory when you empty the trash!
This affected GNOME 2.21.90-91. This is a rather old version of GNOME.
Hass this problem come up in recent times? Is there any current *nix
that uses GNOME 2.21.90 or 2.21.91?
- d.q
>> the Makefile has:
>> EXTRADLLFLAGS = -Wb,-F,KERNEL32.dll -Wl,--image-base,0x7b800000
>
>Is there a good reason for this? Otherwise, this opens a security
>vulnerability in Wine that does not exist in Windows....
This is the way Windows worked before Vista.
(Does Vista actually randomize where even ntdll is?)
BTW our CreateRemoteThread conformance test checks whether
the module has been loaded at a different address, and skips if it
has...
Hi,
I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems clearly right and conforms to what I learn from man pages, etc.
So, I'm hoping somebody who is more familiar with this functionality can review the attached patch before I formally submit it.
Another approach that seems better from my reading of the man pages is to switch to using cfsetspeed() [or cfsetospeed() and cfsetispeed()] instead of having separate branches based on defined(CBAUD). But maybe that has portability problems worse than the current approach.
Thanks,
Ken
All:
Is there documentation anywhere on how to use the TRACE command?
I am trying to print out the contents of a UNICODE string using this commnd.
Thank you.
James McKenzie