Octavian,
>I just looked in mmddk.h and they have this:
>#define MCI_INTEGER64 13
It's good you found out about MCI_INTEGER64. Yet it's completely crazy because
googling it yields 6 hits in total, all about Wine bug 22146.
Bing shows nothing at all. How can such a name be that invisible?
>So, do you want to fix your patches and send them, or do you want me
>to continue working on this patch set?
I'm fine if you do (as I've plenty of other patches in my queue) especially
if you also fix the parser to handle MCI_HWND (another DWORD_PTR),
which is the second half needed for 64bit as I mention in
http://bugs.winehq.org/show_bug.cgi?id=22146#c12
GetDWORD also needs some change to be able to parse DWORD_PTR things,
e.g. window handles. I've not yet written a single test for that (no mciavi tests).
I'll send you all the MCI tests I have written ASAP.
Even without written tests, one can use WINEDEBUG=+mci and analyse the parser logs
for individual commands sent e.g. via the interactive MCI shell you'll find in
http://bugs.winehq.org/show_bug.cgi?id=20232#c10
You obviously own a 64bit system so it's easier for you to test. I don't and had to beg.
Regards,
Jörg Höhle
On 10.08.2010 20:22, Michael Mc Donnell wrote:
> When a user clicks the "Make New Folder" button a new folder is created.
> The name of the folder is selected, and the dialog box waits for the user
> to either accept the name or type in a new one. The test types in a
> new folder name and checks that the new folder gets that name.
Also, you seem to emit “Alt+M” as part of the test. This is rather
fragile, as the hotkey for “Make new folder” is most likely _not_ M on
Windows or Wine translated to other than English.
I believe the safe way to deal with that is to send a WM_COMMAND message
with the ID of the “Make new folder” button.
Wine test bot has a number of non-English VMs, so make sure you try your
patches there.
-f.r.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4987
Your paranoid android.
=== W98SE (32 bit mci) ===
mci.c:889: Test failed: not enough time elapsed 58ms
mci.c:945: Test failed: mci status position: 58
mci.c:992: Test failed: mci pause wait returned MMSYSERR 5
mci.c:1006: Test failed: mci pause (space) wait returned MMSYSERR 5
mci.c:1009: Test failed: mci pause wait returned MMSYSERR 5
mci.c:1023: Test failed: Expect message 0004 from play (aborted by close)
André Hentschel <nerv(a)dawncrow.de> writes:
> ole32 function CoTaskMemAlloc is already used in DLL_PROCESS_ATTACH
> (SIC_Initialize -> SIC_IconAppend -> SHAlloc -> CoTaskMemAlloc)
A better fix would be to avoid initializing unneeded stuff in process
attach.
--
Alexandre Julliard
julliard(a)winehq.org
Austin English <austinenglish(a)gmail.com> wrote:
> +LANGID WINAPI GetThreadUILanguage( void )
> +{
> + FIXME(": stub, returning LOCALE_USER_DEFAULT.\n");
> + return LOCALE_USER_DEFAULT;
> +}
The API is supposed to return a language id, not the locale id.
Calling GetUserDefaultUILanguage() may be what you need.
--
Dmitry.
Can someone with forum admin rights please ban user Eden1023? I've had to delete multiple spam posts by this user every day for the past few days.
--
Rosanne DiMesio <dimesio(a)earthlink.net>
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4950
Your paranoid android.
=== W98SE (32 bit dsound) ===
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D407F4 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D554 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D56C 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D624 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D614 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D614 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D5F4 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D630 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D60C 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D628 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D628 00000000
dsound.c:748: Test failed: Creating 32 bpp buffer on dx < 8 returned: 82D3D628 00000000