Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8775
Your paranoid android.
=== WXPPROSP3 (32 bit msvcr90) ===
msvcr90: unhandled exception c0000005 at 00543C08
=== W2K3R2SESP2 (32 bit msvcr90) ===
msvcr90: unhandled exception c0000005 at 00533C78
=== WVISTAADM (32 bit msvcr90) ===
msvcr90: unhandled exception c000001d at 00D5129D
=== W2K8SE (32 bit msvcr90) ===
msvcr90: unhandled exception c0000005 at 01961298
=== W7PRO (32 bit msvcr90) ===
msvcr90: unhandled exception c000001d at 009212A5
=== W7PROX64 (32 bit msvcr90) ===
msvcr90: unhandled exception c000001d at 005212A4
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8768
Your paranoid android.
=== WXPPROSP3 (32 bit visual) ===
No test summary line found
Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:
> If there is no current clipping region ExtSelectClipRgn(hdc, hrgn, RGN_DIFF)
> creates its own default clipping region which in most cases doesn't match
> neither a visible region nor the window extents attached to the DC.
It will get intersected with the visible region anyway, so it shouldn't
matter as long as it's large enough. Why does it make a difference?
--
Alexandre Julliard
julliard(a)winehq.org
Peter Schlaile <peter(a)schlaile.de> writes:
> Fix: X11DRV_SetDIBits() shouldn't silently change Bitmap protection, so
> we now restore the protection bits, that were present before instead of
> always changing to READONLY.
No, it needs to be read-only so that we can detect further changes.
> Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but
> should test for alpha channel != 255.
No it shouldn't, 0 is correct.
--
Alexandre Julliard
julliard(a)winehq.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I just noticed that I sent the other two mails with my gmail account, so they got stuck in moderation. This patch should apply on its own, but depending on what Alexandre commits today I'll resend the patches after today's commit wave.
Am 31.01.2011 um 11:21 schrieb Stefan Dösinger:
> The alternative to this patch is to remove the test entirely, as it now accepts all possible outcomes on windows. I prefer to keep it because the behavior it accepts as non-broken(invalid viewport = "default" viewport) is required by some ddraw apps. We also have a test in ddraw, but it isn't quite as straightforward.
>
> <0011-d3d9-account-for-another-different-behavior-in-the-v.patch>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
iQIcBAEBAgAGBQJNRsifAAoJEN0/YqbEcdMwUSAP/2HphIB7RzKXuS/q52t5mCvt
b9yFQ/9ci11GWlzWG7okm72Z+hUdC4bIMPxIalWM7/VKPzsSB7Qg2EvwpMTGq0r5
lAX3WFFqWqCNoAZd7JnQO6LqX0TR4wJOCxIjAYSw+WlZW7tYNVFEsw3mPTUxqggR
88wVQ8C5oBAW3Rns6QGYmxyw+R6Xryh3pdukxBP2DS6jQDkqodq9L6JU24YHHy0z
OFEZCIAl8VqhTfgTeO5pqJ7e4ujGyT0U25h8rmIuhMt8DFRdxTSE4agib4haFrLb
jLEUAVqjSrV4EX1A+iisryBYCCOGpGT9vYKB5Xw169fzkjd2XMQ9C3udE/VznGWo
grcWX9CJxm1XzR/AYuNh+pNSq+wZPxwrlJrOmcW4EC1o1X/OdXr+KtZFX2ldkGwF
v6LCel4WPN5G4+mKryNnPMRDPo69ccZr2iKTdMQFs7nm0NZGxPNnj3o7eGDP92pq
DNUboQ3EoZ3ow9c8vpfeGgxk647jgJwpeOzUKj7ON3l5XyFvoEAAv2pFwRp/lpn8
3ioLYDePd7VBcf6cT9ckI0Qptx2hM8yRyd1r+qC4jGv8ydQnHmAu+w61cmSrpl3X
EYpvHmFYEdkJjDKcn2Z1gYekg4RisXcd/CVBWfZHLudpibEab+3NQp7wb+HwNscu
2P/hz0RIdqEC7BBQf6bJ
=Vxnq
-----END PGP SIGNATURE-----
Hi again,
I've been working to implement the tests for RtlCaptureStackBackTrace(), but I have encountered a problem. The function, according to MSDN should be available only in Windows XP and newer OSes.
Now, when I ran these tests on Testbot using all base VMs, the tests were run also on W2KPROSP4 and WNT4WSSP6. However, the function seems to buggy in those. It throws access violation whenever it is not skipping frames.
Here's the test patch I used:
http://testbot.winehq.org/GetFile.pl?JobKey=8606&StepKey=1
In both cases, test on patch's line 83 failed and call on line 92 crashed the test.
In other VMs the tests succeeded and none crashed.
Is there some way I could prevent/skip these tests to be run on Windows NT4 and 2000?
Best Regards,
Janne Hakonen
On 01/30/2011 04:16 AM, Peter Schlaile wrote:
> Hi,
>
> find fix for a crash in create_alpha_bitmap() attached.
If it's easy to reproduce please create a test that demonstrates the problem.
> Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but
> should test for alpha channel != 255.
This should be a separate patch.
Vitaliy.
All:
Constructive Criticism requested so that this can be made better.
I've decided to use two loops in the test: One for fonts. Second for
actual tests. This allows for quick and easy expansion. The check code
for font changes might be removed, but does no harm by remaining. This
patch is based on git as of Friday, January 28.
I could find no font that changed the Margin from zero for the
EC_USEFONTINFO lparam test case. If someone knows of a font that will
do so, please advise as well so I can include it.
Thank you.
James McKenzie