Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26897
Your paranoid android.
=== WVISTAX64 (64 bit comm) ===
comm.c:835: Test failed: WriteFile took 16 ms to write 0 Bytes at 150 Baud
comm.c:1445: test_AbortWaitCts timeout 500 handle 000000000000003C
comm.c:1412: Changing CommMask on the fly for handle 000000000000003C after timeout 500
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26894
Your paranoid android.
=== WXPX64 (32 bit msvcr90) ===
No test summary line found
Am Dienstag, 27. August 2013, 22:00:59 schrieben Sie:
> Wolfgang Walter <wine(a)stwm.de> wrote:
> > > Wolfgang Walter <wine(a)stwm.de> wrote:
> > > > I made similar changes so that several applications we use work. I
> > > > tested
> > > > your patches, all but one do work. I don't know why one does not,
> > > > though.
> > >
> > > What patch doesn't work for you?
> >
> > I tested all your patches together (indivually they will not really work
> > here).
>
> Yeah, the patches need to be tested after applying all of them. They were
> broken into smaller parts in order to make regression test easier in case of
> a regression. If I don't know what doesn't work I can't make any
> improvement.
Yes, that's clear. I'll have a closer look what's the main difference. The
problematic application uses asynchronous IO.
I wrote my patch 2009 (and earlier version 2008) so I have to rethink about
it. I remember that TX_TXEMPTY detection was a problem, then. It could get
lost.
The reason I moved the output buffer empty detection from get_irq_info() into
check_events() was simply because I thought handling input queue in
check_events() but ouput queue in get_irq_info() seems odd.
I also think that it's better to detect that get_irq_info() basicly does not
work with drivers not supporting TIOCGICOUNT and it is good to have that
information in the callers of get_irq_info(). So I return
STATUS_NOT_IMPLEMENTED and handle the situation in the caller. And then it is
better to move empty sending queue handling out of get_irq_info().
I handle the TIOCSERGETLSR wrong, as I see now (I should & with TIOCSER_TEMT).
Regards,
--
Wolfgang Walter
Studentenwerk München
Anstalt des öffentlichen Rechts
Abteilungsleiter IT
Leopoldstraße 15
80802 München
Folks,
I am writing to announce that we will be retiring the original Wine Test
Bot, written by the late Ge van Geldorp, as of August 31, 2013.
We will switch over to the new test bot that Francois has been working
on at that time. On September 1, we'll panic and fix everything that is
broken <grin>).
I want to thank Ge's family, notably his brother Arno, for keeping the
servers running these years since Ge passed away.
It's also important to note how incredible a contribution the Wine Test
Bot has proven to be for the Wine project; Wine owes an incredible debt
to Ge, and I hope we can all collectively work to remember the great
gift he gave us and the world.
Cheers,
Jeremy
--Sorry about the HTML in the earlier message.
>> Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.
>Is that with the ubuntu-wine ppa enabled?
There are two answers to that question, surprisingly.
(1) bitbox
In the instructions it looks like the wine ppa repository can be installed the Debian way. But I did that and here's the result.
----------------
E: You must put some 'source' URIs in your sources.list
----------------
So, I had to add the wine-ppa by manually adding to the sources.list.
(2) non bitbox
This morning a new version of the i386 photo function was added, and now the depencencies install.
Conclusion:
This afternoon I was able to update all dependencies and compile without a problem using (with modifications above) the bitbox instructions.
Compiled only. Did not install because I needed symlinks, but at least I know where I am and what I have to do.
Susan
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26885
Your paranoid android.
=== W2KPROSP4 (32 bit job) ===
job: unhandled exception c0000005 at 00000000
Hello,
I made similar changes so that several applications we use work. I tested your
patches, all but one do work. I don't know why one does not, though.
I attached my patch, maybe it is usefull to you.
Regards,
--
Wolfgang Walter
Studentenwerk München
Anstalt des öffentlichen Rechts
Abteilungsleiter IT
Leopoldstraße 15
80802 München
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
> +static OLEMISC get_olemisc_value(const WCHAR *str, int len)
> +{
> + int min, max;
> +
> + min = 0;
> + max = ARRAY_SIZE(olemisc_values) - 1;
> +
> + while (min <= max)
> + {
> + int n, c;
> +
> + n = (min+max)/2;
> +
> + c = memcmp(olemisc_values[n].name, str, min(len, olemisc_values[n].len)*sizeof(WCHAR));
> + if (!c)
> + {
> + if (olemisc_values[n].len < len)
> + c = -1;
> + else if (olemisc_values[n].len > len)
> + c = 1;
> + }
Actually, memcmp is not a good choice for comparing Unicode strings. It
doesn't make a difference for ASCII-only strings, but it would still be
cleaner to do it right. strncmpW is preferable (as long as you use it
correctly...)
--
Alexandre Julliard
julliard(a)winehq.org
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26878
Your paranoid android.
=== WVISTAX64 (32 bit comm) ===
comm.c:835: Test failed: WriteFile took 16 ms to write 0 Bytes at 150 Baud
comm.c:1443: test_AbortWaitCts timeout 500 handle 000000B4
comm.c:1410: Changing CommMask on the fly for handle 000000B4 after timeout 500