Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=24024
Your paranoid android.
=== w7u (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w7pro64 (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w8 (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w864 (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w7pro64 (64 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w864 (64 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=24023
Your paranoid android.
=== w7u (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w7pro64 (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w8 (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w864 (32 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w7pro64 (64 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
=== w864 (64 bit internet) ===
internet.c:366: Test failed: InternetGetCookie should have failed with FALSE and error 14
Rob Walker <bob.mt.wya(a)gmail.com> writes:
> Workaround for https://bugs.winehq.org/show_bug.cgi?id=40828
A better approach would be to detect the fullscreen window and
automatically hide the taskbar.
--
Alexandre Julliard
julliard(a)winehq.org
+ if (using_root)
+ {
+ enable_shell = FALSE;
+ initialize_systray( graphics_driver, using_root,
enable_shell );
+ }
+ else
+ {
+ enable_systray=get_default_systray_state();
+ initialize_systray( graphics_driver, !enable_systray,
enable_shell );
+ }
I think you should put the same whitespace around the equals sign in both cases.
-Alex
Akihiro Sagawa <sagawa.aki(a)gmail.com> writes:
> Try 8:
> - Fix user32 test failures. To achieve this, we create the default IME window
> as message-only window for now.
This doesn't match Windows behavior, as the tests show:
../../../tools/runtest -q -P wine -T ../../.. -M imm32.dll -p imm32_test.exe.so imm32 && touch imm32.ok
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:946: Test failed: Expected IME window existence
imm32.c:948: Test failed: Expected (nil), got 0x30066
imm32.c:195: Test failed: expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:956: Test failed: Expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:994: Test failed: Expected IME window existence
imm32.c:996: Test failed: Expected (nil), got 0x50066
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:946: Test failed: Expected IME window existence
imm32.c:948: Test failed: Expected (nil), got 0x60066
imm32.c:195: Test failed: expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:956: Test failed: Expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:994: Test failed: Expected IME window existence
imm32.c:996: Test failed: Expected (nil), got 0x80066
imm32.c:946: Test failed: Expected IME window existence
imm32.c:948: Test failed: Expected (nil), got 0xb005e
imm32.c:195: Test failed: expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:956: Test failed: Expected IME window existence
imm32.c:946: Test failed: Expected IME window existence
imm32.c:948: Test failed: Expected (nil), got 0x20040
imm32.c:195: Test failed: expected IME window existence
imm32.c:209: Test failed: expected IME window existence
imm32.c:221: Test failed: expected IME window existence
imm32.c:956: Test failed: Expected IME window existence
make: *** [imm32.ok] Error 40
--
Alexandre Julliard
julliard(a)winehq.org
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=23920
Your paranoid android.
=== wxppro (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2003std (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== wvistau64 (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2008s64 (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7u (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7pro64 (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w8 (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w864 (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w1064 (32 bit eventlog) ===
eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87
eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87
eventlog.c:1272: Test failed: Expected success
eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
Hi Max,
On 03.07.2016 23:41, Max Qian wrote:
> diff --git a/include/wincrypt.h b/include/wincrypt.h
> index 55c9509..19af6ca 100644
> --- a/include/wincrypt.h
> +++ b/include/wincrypt.h
> @@ -1583,6 +1583,7 @@ typedef const CERT_CRL_CONTEXT_PAIR *PCCERT_CRL_CONTEXT_PAIR;
> #define ALG_SID_AGREED_KEY_ANY 3
> #define ALG_SID_KEA 4
> #define ALG_SID_ECDH 5
> +#define ALG_SID_ECDH_EPHEM 6
> /* RC2 SIDs */
> #define ALG_SID_RC4 1
> #define ALG_SID_RC2 2
> @@ -1639,6 +1640,7 @@ typedef const CERT_CRL_CONTEXT_PAIR *PCCERT_CRL_CONTEXT_PAIR;
> #define CALG_KEA_KEYX (ALG_CLASS_KEY_EXCHANGE | ALG_TYPE_DH | ALG_SID_KEA)
> #define CALG_HUGHES_MD5 (ALG_CLASS_KEY_EXCHANGE | ALG_TYPE_ANY | ALG_SID_MD5)
> #define CALG_ECDH (ALG_CLASS_KEY_EXCHANGE | ALG_TYPE_DH | ALG_SID_ECDH)
> +#define CALG_ECDH_EPHEM (ALG_CLASS_KEY_EXCHANGE | ALG_TYPE_DH | ALG_SID_ECDH_EPHEM)
> #define CALG_RSA_KEYX (ALG_CLASS_KEY_EXCHANGE | ALG_TYPE_RSA | ALG_SID_RSA_ANY)
> #define CALG_ECMQV (ALG_CLASS_KEY_EXCHANGE | ALG_TYPE_ANY | ALG_SID_ECMQV)
> #define CALG_DES (ALG_CLASS_DATA_ENCRYPT | ALG_TYPE_BLOCK | ALG_SID_DES)
Do you have a version of PSDK that has this definition? I can't see it
here. If those are not in MS headers, we shouldn't have them unless we
have a strong reason. When I asked you about adding a comment, I was
hoping for something like
/* MSDN mentions CALG_ECDH_EPHEM, but it's not available in headers. */
case ....: return CALG_ECDH;
Thanks,
Jacek