On 07/24/16 20:40, Nikolay Sivov wrote:
> +/*********************************************************************
> + * _get_narrow_winmain_command_line (UCRTBASE.@)
> + */
> +char* CDECL _get_narrow_winmain_command_line(void)
> +{
> + static char *narrow_command_line;
> + char *s;
> +
> + if (narrow_command_line)
> + return narrow_command_line;
> +
> + s = GetCommandLineA();
> + if (*s == '"')
> + {
> + s++;
> + while (*s)
> + if (*s++ == '"')
> + break;
> + }
> + else
> + {
> + while (*s && *s != ' ' && *s != '\t')
> + s++;
> + }
> + while (*s == ' ' || *s == '\t')
> + s++;
> +
> + return narrow_command_line = s;
> +}
It will not work in following case (executable name "test ws.exe"):
CMD> test" "ws.exe other args
or
CMD> """test ws.exe" other args
Probably there's no real use case for that but it shouldn't be hard to
handle this cases as well.
Thanks,
Piotr
Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes:
> When msxml3 is native, msxml2 forwards to msxml3 which then fails
> to create an object. On Windows 8.1, Msxml2.DOMDocument
> point to Msxml2.DOMDocument.3.0.
That should be the case on Wine too. It sounds like there's something
broken with your config. Note that mixing native and builtin is not a
good idea.
--
Alexandre Julliard
julliard(a)winehq.org
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=24498
Your paranoid android.
=== wvistau64 (32 bit layout) ===
The test timed out
On Sat, Jul 23, 2016 at 8:01 AM, Corentin Rossignon <corossig(a)gmail.com> wrote:
> Signed-off-by: Corentin Rossignon <corossig(a)gmail.com>
> ---
> dlls/dinput/joystick_linux.c | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
Thanks for the patch, I just tested and they work with my gamepads.
Since you will have to fix the problems below I suggest that you
resend the 2 patches with subjects:
[PATCH 1/2] dinput: Retrieve vendor ID and product ID in Linux joystick API
[PATCH 2/2] dinput: Fix product GUID generation in Linux joystick and event API
Formatting problem:
bruno@Note:~/programs/wine$ git apply dinput1
dinput1:19: trailing whitespace.
dinput1:68: trailing whitespace.
}
warning: 2 lines add whitespace errors.
> + /* Find vendor_id and product_id in sysfs */
> + joydev.vendor_id = 0;
> + joydev.product_id = 0;
> +
> + snprintf(sys_path, MAX_PATH, "/sys/class/input/js%d/device/id/vendor", i);
> + sys_fd = open(sys_path, O_RDONLY);
> + if (sys_path > 0)
> + {
Wrong variable in the condition.
Best Regards,
Bruno