wine-devel August 2016

55 participants
282 discussions

Re: [PATCH 02/11] wined3d: Add WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH flag.

by Matteo Bruni

2016-08-01 22:28 GMT+02:00 Józef Kucia <jkucia(a)codeweavers.com>: > - FIXME("Ignoring SwapEffect and Flags\n"); > + FIXME("Ignoring SwapEffect %#x.\n", desc->SwapEffect); Yes please. I ended up making a similar change for debugging at least twice in separate occasions (even though in neither case the swap effect had anything to do with the issue at hand) but I didn't feel like sending just the trace change and I never completed a patch actually passing the swap effect to wined3d. I still might at some point, but in the meantime I'd love to see the actual swap effect traced.

7 years, 9 months

wine-1.8.4-rc1

by Michael Stefaniuc

Hello guys, I have pushed wine-1.8.4-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Getting nearer to the goal of "around 50" commits for a stable release as this one contains only 66 commits. Nothing fancy though: - Stubs - More GPUs added - One wined3d fix backported (thanks again to Henri) - One original patch aka not cherry-picked, see below. Should somebody look at the release commit he'll notice that 7 of the bugs were already included in wine-1.8.3. That was a mistake as I had deferred those for a later release. So I've modified tools/make_announce to avoid that mistake in the future. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. Lets see how this works out as I'm on vacation travelling and Alexandre will travel too. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.4 (total 49): 18745 64-bit Mortal Kombat X crashes on unimplemented function KERNEL32.dll.GetLargePageMinimum 20977 Bad hlp table rendering 22819 Some applications like Heroes of Might and Magic 2 display loopback. 25396 Safrosoft RoX freezes at start. 26268 Multiple applications need ntdll.ZwSetLdtEntries stub (kwiksupport.me, Ragnarok Online patcher) 26965 Dragon Age 2 demo - sound in cutscenes is muffled 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 34052 The Witcher: Character models are sometimes invisible 36556 valgrind shows a definite leak in comctl32/tests/syslink.c 36838 TOCA Touring Car Championship: installer copies one file from CD and then shows an error 37063 NTLM EncryptMessage/DecryptMessage failure 37090 Multiple applications crash with built-in amstream (Shogun: Total War, Medieval: Total War) 37271 Applications get IP address of 127.12.34.56 when lo0 is up on OSX 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 38137 WBaduk: "Could not obtain OLE control window handle" regression 38811 Java JRE 8 installer 'jre-8uXX-windows-i586.exe' crashes on startup (GetThreadPreferredUILanguages is a stub) 38962 expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39579 iNode 3.6 client needs ndis.sys.NdisAllocateMemoryWithTag 39842 Skype for windows doesn't work (needs ndis.sys.NdisSystemProcessorCount) 39911 dxd9 PresentationInterval not propagated on device Reset 39933 iNode 3.6 client needs ndis.sys.NdisAllocateSpinLock 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40301 wxDatePickerCtrl (wxWidgets) generates an assert on DTM_GETRANGE message result 40380 Wine should take dosbox's configuration instead of creating a new one 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40497 "Trainz: A New Era" needs msvcr120.dll.?__ExceptionPtrToBool@@YA_NPEBX@Z 40511 Application that copies files from one place to another stoped working in wine versions greater then 1.6.2 40532 Microsoft Word Viewer 11.8 does not show text on file properties dialog until the text is selected 40557 KSP Trajectory Optimization Tool (MATLAB Runtime (MCR)) crashes at launch 40562 AkelPad: [ToolBar plugin] tooltips for toolbar buttons have some extra text 40581 Regression: dsound input recording from microphone lags with 2 seconds delay 40614 Cisco Jabber 11.6 crashes due to missing dbghelp.dll.EnumerateLoadedModulesExW 40618 Autodesk 123D Design needs msvcr100.dll.mbsrtowcs_s 40659 Window with CS_OWNDC style cause DC leak when GetDC/ReleaseDC is used. 40691 DVDFab 9.2.4.4 pre-check FabCheck.exe executable fails, needs setupapi.dll.CM_Get_DevNode_Status 40745 Python 3.5.1 interpreter crashes, needs _set_thread_local_invalid_parameter_handler 40747 Microsoft Expression Web 4 crashes on startup, needs gdiplus.dll.GdipGetImageAttributesAdjustedPalette 40754 GOG Galaxy crashes with unimplemented function api-ms-win-crt-locale-l1-1-0.dll._lock_locales 40755 GOG Galaxy crashes with unimplemented function ucrtbase.dll._lock_locales 40756 GOG Galaxy crashes with unimplemented function api-ms-win-crt-heap-l1-1-0.dll._calloc_base 40770 Nvidia GeForce GT 730 not recognized properly 40796 Python 3.5.1 interpreter crashes when importing pyqtSlot 40830 Conflict between kVK_RightCommand and macOS 10.12 Sierra in carbon framework 40833 Batman: Arkham Origins Blackgate no sound during gameplay (except cutscenes) 40851 macOS 10.12 Build Failure in winspool.drv with cupsGetPPD 40923 Alone in the Dark (2008) crashes on launch with msvcrt assertion ---------------------------------------------------------------- Changes since 1.8.3: Alex Henrie (6): msvcrt: Stub out _(get|set)_thread_local_invalid_parameter_handler. ucrtbase: Implement _(un)lock_locales. ucrtbase: Implement _calloc_base. ucrtbase: Implement _malloc_base. ucrtbase: Implement _free_base. riched20: Don't call UpdateWindow after setting the background color. Alexandre Julliard (1): user32: Completely free owned DCEs when the corresponding window/class is destroyed. Alistair Leslie-Hughes (2): wininet: Free socket when connection is freed. wined3d: Correct memory size for Geforce 9600 GT. Andrew Eikum (3): dsound: Support downmixing 5.1 to stereo. dsound: Capture all available data on each period callback. xaudio2: Always set current OpenAL context before making AL calls. André Hentschel (1): ndis.sys: Implement NdisSystemProcessorCount. Austin English (12): hal: Add READ_PORT_ULONG stub. hal: Add READ_PORT_UCHAR stub. hal: Add WRITE_PORT_ULONG stub. kernel32: Add FreeUserPhysicalPages stub. winsta: Add a stub for WinStationEnumerateW. dwmapi: Add DwmSetPresentParameters stub. kernel32: Add GetConsoleAliasExesLengthA/W stubs. ntdll: Add NtSetLdtEntries/ZwSetLdtEntries stub. dbghelp: Add forwards for EnumerateLoadedModulesEx/EnumerateLoadedModulesExW. kernel32: Implement GetLargePageMinimum. ndis.sys: Add NdisAllocateMemoryWithTag stub. ndis.sys: Add NdisAllocateSpinLock stub. Benjamin Hodgetts (1): wined3d: Add Intel Iris chips to identification list. Bruno Jesus (1): ws2_32: Ensure default route IP addresses are returned first in gethostbyname. Béla Gyebrószki (2): wined3d: Add Nvidia GeForce GTS 250. wined3d: Add Nvidia GeForce GT 730 (GK208). David Woodhouse (1): secur32: Fix handling of ANSI NTLM credentials. Fabian Maurer (1): msacm32: Added converter for ADPCM to PCM 8 bit mono. Grazvydas Ignotas (3): wined3d: Use Intel data returned by Windows driver. wined3d: Add some more Intel GPUs. wined3d: Add a fallback for Skylake. Hans Leidekker (1): kernel32: Improve the stub for GetThreadPreferredUILanguages. Henri Verbeet (1): wined3d: Also update the swap interval when not recreating the context in wined3d_device_reset(). Jarkko Korpi (1): widl: Fix overflow when left-shifting. Jean-Christophe Cardot (6): winhlp32: Replace magic numbers by symbols. winhlp32: Add some trace calls. winhlp32: Add a warning trace. winhlp32: Prepare winhlp32 for more font types. winhlp32: Rework and rename HLPFILE_HalfPointsToTwips. winhlp32: Fix table formatting. Justas Lavišius (1): include: Force stack alignment on x86_64. Ken Thomases (2): winspool.drv: Include <cups/ppd.h> to fix building against the macOS 10.12 SDK. winemac: Don't define kVK_RightCommand when building against the macOS 10.12 SDK. Luis Sahagun (1): winevdm: Tell dosbox to read the current user's config. Matteo Bruni (1): wined3d: Add a setting to check relative addressing indices when accessing uniforms. Michael Müller (1): amstream: Implement IDirectDrawMediaStream::GetMultiMediaStream. Michael Stefaniuc (1): tools: Get the bug list for ANNOUNCE from the stable-notes git notes. Nikolay Sivov (2): comctl32/datetime: Use MCM_GETRANGE result directly in DTM_GETRANGE. comctl32/tooltips: Cut tooltip text at first tab char unless TTS_NOPREFIX is used. Olivier F. R. Dierick (1): shell32: Set last error explicitly in SHFileOperation(). Piotr Caban (6): msvcrt: Add mbsrtowcs_s implementation. msvcp110: Fix num_put<char> structure layout. msvcrt: Fix mbtowc behavior for buffers containing more than one character. ieframe: Restore closed IOleClientSite in DoVerb. msvcr120: Add __ExceptionPtrToBool implementation. msvcrt: Return error when previously parsed type is accessed while demangling simple data type. Rob Walker (1): setupapi: Add stub for setupapi.dll.CM_Get_DevNode_Status. Sebastian Lackner (3): comctl32/syslink: Fix a blocks leak (Valgrind). amstream/tests: Add tests for GetMultiMediaStream methods. server: Fix assignment of primary_group in token_duplicate. Stefan Leichter (3): kernel32: Add stub for GetSystemPreferredUILanguages. kernel32/tests: Add tests for GetSystemPreferredUILanguages. kernel32: Return a dummy value in GetSystemPreferredUILanguages. Vincent Povirk (1): gdiplus: Implement GdipGetImageAttributesAdjustedPalette. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

7 years, 9 months

Re: [v2 4/6] msvcirt: Implement istream::operator>> for integers.

by Piotr Caban

On 08/02/16 13:37, Iván Matellanes wrote: > +static istream* istream_internal_read_unsigned_integer(istream *this, void *p, int size) > +{ > + /* size: 0 => short, 1 => int, 2 => long */ > + ios *base = istream_get_ios(this); > + char buffer[16]; > + int num_base; > + LONG min_value[3] = {SHRT_MIN, INT_MIN, LONG_MIN}; > + ULONG umax_value[3] = {USHRT_MAX, UINT_MAX, ULONG_MAX}, tmp; Shouldn't min_value be equal to 0? How about changing the helper functions to have following prototypes: static LONG istream_internal_read_integer(istream *this, LONG min_value, LONG max_value); and static ULONG istream_internal_read_unsigned_integer(istream *this, ULONG max_value); I think the code will be nicer this way. Thanks, Piotr

7 years, 9 months

Re: [v2 5/6] msvcirt: Implement istream::operator>> for floats.

by Piotr Caban

On 08/02/16 13:37, Iván Matellanes wrote: > +static istream* istream_internal_read_float(istream *this, void *p, int size) > +{ > + /* size: 0 => float, 1 => double, 2 => long double */ > + const int max_chars[3] = {20, 28, 32}; /* character count is limited on Windows */ > + char buffer[32]; > + double d; > + > + TRACE("(%p %p %d)\n", this, p, size); > + > + if (istream_ipfx(this, 0)) { > + if (istream_getdouble(this, buffer, max_chars[size]) > 0) { > + d = strtod(buffer, NULL); > + if (size == 0) { > + /* check whether the value fits in the output var */ > + if (d > FLT_MAX) > + d = FLT_MAX; > + else if (d < -FLT_MAX) > + d = -FLT_MAX; > + else if (d > 0 && d < FLT_MIN) > + d = FLT_MIN; > + else if (d < 0 && d > -FLT_MIN) > + d = -FLT_MIN; > + *((float*) p) = d; I think that this helper will be nicer if it has following prototype: static double istream_internal_read_float(istream *this, int max_chars); where max_chars is set to 20, 28 or 32 depending if float, double or LDOUBLE needs to be read. With FLT_MIN/FLT_MAX checks moved to operator>>(float) implementation. Thanks, Piotr

7 years, 9 months

Re: [v2 3/6] msvcirt: Implement istream::operator>> for strings.

by Piotr Caban

On 08/02/16 13:37, Iván Matellanes wrote: > @@ -3514,7 +3514,28 @@ istream* __thiscall istream_read_char(istream *this, char *ch) > DEFINE_THISCALL_WRAPPER(istream_read_str, 8) > istream* __thiscall istream_read_str(istream *this, char *str) > { > - FIXME("(%p %p) stub\n", this, str); > + ios *base = istream_get_ios(this); > + int ch, count = 0; > + > + TRACE("(%p %p)\n", this, str); > + > + if (istream_ipfx(this, 0)) { > + for (ch = streambuf_sgetc(base->sb); > + str && count < (unsigned int) base->width - 1 && !isspace(ch); > + ch = streambuf_snextc(base->sb)) { streambuf_sgetc shouldn't be called if str == NULL. Thanks, Piotr

7 years, 9 months

Re: [PATCH 2/5] mpr: Implement provider selection given remote name.

by Nikolay Sivov

On 02.08.2016 14:31, Pierre Schweitzer wrote: > + len = WideCharToMultiByte(CP_ACP, 0, provider->lpProvider, -1, NULL, 0, NULL, NULL); > + provider_name = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (provider_name) > + memcpy(provider_name, provider->lpProvider, len * sizeof(WCHAR)); > + > + HeapFree(GetProcessHeap(), 0, provider); > + > + return provider_name; This is confusing. WNetGetResourceInformationW return W string, you convert it to A, and use A length to allocate another W buffer? What's going on?

7 years, 9 months

Re: [PATCH 4/5] mpr: Implement WNetCancelConnectionA(), WNetCancelConnectionW(), WNetCancelConnection2A().

by Nikolay Sivov

This looks okay to me.

7 years, 9 months

Re: [PATCH 1/5] mpr: Implement local name automatic redirection for disks. (try 3)

by Nikolay Sivov

On 02.08.2016 14:31, Pierre Schweitzer wrote: > + FIXME("Locale device selection is not implemented for printers.\n"); > + return WN_NO_NETWORK; This should be 'local', and not 'locale'.

7 years, 9 months

Re: [PATCH 1/5] mpr: Implement local name automatic redirection for disks. (try 3)

by Nikolay Sivov

On 02.08.2016 14:31, Pierre Schweitzer wrote: > This fixes a bug seen during review for ReactOS commit: in case of local > redirection, the name wasn't properly converted back to ANSI for A callers. > > > -static void use_connection_set_accessnameW(struct use_connection_context *ctxt) > +static void use_connection_set_accessnameW(struct use_connection_context *ctxt, WCHAR *local_name) > { > WCHAR *accessname = ctxt->accessname; > - if (ctxt->resource->lpLocalName) > - strcpyW(accessname, ctxt->resource->lpLocalName); > + if (local_name) > + strcpyW(accessname, local_name); > else > strcpyW(accessname, ctxt->resource->lpRemoteName); > } You already have lpLocalName here, why another argument?

7 years, 9 months

Re: [PATCH 3/5] mpr: Implement WNetCancelConnection2W().

by Nikolay Sivov

On 02.08.2016 14:31, Pierre Schweitzer wrote: > Resending just for offsets > > + if(providerTable->table[index].getCaps(WNNC_CONNECTION) & > + WNNC_CON_GETCONNECTIONS) > + { > + if (providerTable->table[index].cancelConnection) > + ret = providerTable->table[index].cancelConnection((LPWSTR)lpName, fForce); > + else > + ret = WN_NO_NETWORK; > + if (ret == WN_SUCCESS || ret == WN_OPEN_FILES) > + break; > + } I already asked about this before. Why is this using WNNC_CON_GETCONNECTIONS and not WNNC_CON_CANCELCONNECTION?

7 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel August 2016