I did not get to send this patch set yet so here's a preview:
* Windows test patterns
http://fgouget.free.fr/tmp/winepatterns/patterns-tb-win.html
* Wine test patterns
http://fgouget.free.fr/tmp/winepatterns/patterns-tb-wine.html
So for each test unit that had failures you have:
* one line per test configuration (report tag)
* one row per WineTest build (daily commit)
Each cell has a one character description of the test result (with more
details in the tooltip) and is color coded to help identify patterns.
Each 'failure' cell also links to the corresponding report page.
The main goal of these pages for me is to simplify detecting new
failures in the WineTest results... and not just in cases where there
was no failure before since there are so many cases with preexisting
failures already. In the patterns an increase in the number of failures
shows up as a color change which makes them easy to spot.
A secondary goal is to allow comparing the before/after results when a
test configuration (VM or otherwise) is modified.
A side effect is that these can also help identify the different failure
modes. For instance comctl32:monthcal fails on wednesdays, except in
Korean where it's all the time:
http://fgouget.free.fr/tmp/winepatterns/patterns-tb-win.html#comctl32:month…
To help with these tasks the page also sorts the test units to show
those that look like they have new failures first. So starting the
review from the top is most likely to point to the new issues.
--
Francois Gouget <fgouget(a)codeweavers.com>
Don't skip MoveCaret if it would actually change the selection when it is
invalid. This can happen, for example, in a combo box if the dropdown is
shown by a mouse click + release followed by the mouse being moved into
the dropped listbox, when the listbox has nothing selected. In this case,
the item with the index zero would not be selected the first time the mouse
moves over it, since the focus_item would be zero.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com>
---
This can be easily tested with winecfg. Launch winecfg, go to `Libraries`
tab, click on the combobox arrow dropdown for `New override for library`
to open the listbox, then hover the mouse over the first entry (acledit).
Notice that it does not get highlighted, which is the issue. If you move
the mouse to the second entry (aclui) and then back to (acledit), it works.
With this patch, the first hover over the first entry will also work as
it should.
dlls/comctl32/listbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/comctl32/listbox.c b/dlls/comctl32/listbox.c
index 239f54a..1f5d3c9 100644
--- a/dlls/comctl32/listbox.c
+++ b/dlls/comctl32/listbox.c
@@ -2337,7 +2337,7 @@ static LRESULT LISTBOX_HandleTimer( LB_DESCR *descr, INT index, TIMER_DIRECTION
case LB_TIMER_NONE:
break;
}
- if (index == descr->focus_item) return FALSE;
+ if (index == descr->focus_item && descr->selected_item != -1) return FALSE;
LISTBOX_MoveCaret( descr, index, FALSE );
return TRUE;
}
--
2.30.0