31 Oct
2008
31 Oct
'08
2:52 p.m.
Hans Leidekker <hans(a)codeweavers.com> at Oct 31, 2008 5:32 AM wrote about Re:
wininet: let automated testers force all DNS lookups to return localhost
This would not work on Macs as /etc/hosts is locked to admins only and would be a
problem to implement.
James McKenzie
Only include
this in debugging builds.
What happened to your /etc/hosts proposal? It has the
advantage that we don't need changes to Wine source code.
31 Oct
31 Oct
3:11 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
2008/10/31 James Mckenzie <jjmckenzie51(a)earthlink.net>et>:
This would not work on Macs as /etc/hosts is locked to
admins only and would be a problem to implement.
I don't see how that's a problem, or how that's different from eg.
Linux.
More on-topic, I don't think it would be hard to do some LD_PRELOAD
hacks on getaddrinfo(), gethostbyname(), and whatever else is
appropriate.
3:39 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
On Fri, Oct 31, 2008 at 8:11 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
2008/10/31 James Mckenzie
<jjmckenzie51(a)earthlink.net>et>:
How would we do this on Windows? (We need the
winetest results to be reliable, too.)
That was the main reason I didn't go for LD_PRELOAD...
I guess we do some sort of DLL injection, but I haven't done
it personally before.
- Dan
This would not work on Macs as /etc/hosts is
locked to admins only and would be a problem to implement.
I don't see how that's a problem, or how that's different from eg.
Linux.
More on-topic, I don't think it would be hard to do some LD_PRELOAD
hacks on getaddrinfo(), gethostbyname(), and whatever else is
appropriate.
3:51 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
2008/10/31 Dan Kegel <dank(a)kegel.com>om>:
How would we do this on Windows? (We need the
winetest results to be reliable, too.)
That was the main reason I didn't go for LD_PRELOAD...
I guess we do some sort of DLL injection, but I haven't done
it personally before.
- Dan
You could patch the IAT, but that's quite a bit less nice than
LD_PRELOAD, of course.
4:06 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
On Fri, Oct 31, 2008 at 8:51 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
2008/10/31 Dan Kegel <dank(a)kegel.com>om>:
The thing is, I want to support running tests on Windows as well.
May as well do it the same way everywhere...
- Dan
How would we do this on Windows? (We need the
winetest results to be reliable, too.)
That was the main reason I didn't go for LD_PRELOAD...
I guess we do some sort of DLL injection, but I haven't done
it personally before.
You could patch the IAT, but that's quite a bit less nice than
LD_PRELOAD, of course.
2 Nov
2 Nov
6:58 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
Rob wrote:
Sure it would; just make the test server setup script run on cygwin properly.
Later we
should provide a script to set up
a local test server that can handle all of
our conformance tests' requests, but for
now, just letting patchwatcher or winetest
redirect everything to localhost will let tests
fail reliably instead of randomly.
This approach won't help users of the Wine conformance
tests running on Windows, We should instead rewrite any existing tests that
use a public server to instead use a server started
by the Wine test code (see dlls/wininet/tests/http.c:server_thread).
Yes, absolutely. The more tests that set up their own mock servers, the better.
But while we're waiting for that, a "nuke DNS resolution"
approach makes tests behave repeatably, and would
even be useful after we implement the fix you propose,
as it would protect us from new tests that sloppily depend on
the public internet.
As someone pointed out, actually nuking DNS resolution
is kind of tricky; my patch did it for DLLs that use win32
networking, but not for DLLs that use native networking.
It probably can't be done the same way everywhere,
so I guess for Linux I'll punt and try shared library overriding.
- Dan
3 Nov
3 Nov
9:50 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
On So, 2008-11-02 at 10:58 -0800, Dan Kegel wrote:
require an installed cygwin is broken by design.
winetest.exe is a standalone application.
That will add a lot of code.
Add a local_server.c for every dll that need it is another Idea.
I prefer to have a winetest.dll for that.
A winetest.dll / winetest.sys allow us to create even more tests.
(Global Hooks and Device Drivers as examples)
--
By by ... Detlef
This approach
won't help users of the Wine conformance
tests running on Windows,
Sure it would; just make the test server setup script run on cygwin properly. We should
instead rewrite any existing tests that
use a public server to instead use a server started
by the Wine test code (see dlls/wininet/tests/http.c:server_thread).
Yes,
absolutely.
9:53 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
On Mon, Nov 3, 2008 at 1:50 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote:
require an installed cygwin is broken by design.
winetest.exe is a standalone application.
It wouldn't be required. You'd only need to run the
script if you wanted to avoid relying on winehq.org.
I prefer servers built into wine's conformance test suite.
But if we're going to keep using external servers, we
should at least document which ones we use,
and how to set them up.
Go for it...
- Dan
This approach won't help users of the Wine
conformance
tests running on Windows,
Sure it would; just make the test server setup script run on cygwin properly. > We should
instead rewrite any existing tests that
> use a public server to instead use a server started
> by the Wine test code (see dlls/wininet/tests/http.c:server_thread).
I prefer to have a winetest.dll for that.
A winetest.dll / winetest.sys allow us to create even more tests.
(Global Hooks and Device Drivers as examples) 
31 Oct
31 Oct
3:11 p.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
On Friday 31 October 2008 15:52:43 James Mckenzie wrote:
That's true for Unix in general, but I think we require admin rights
already because the services need to bind ports below 1024 for example.
-Hans
What happened
to your /etc/hosts proposal? It has the
advantage that we don't need changes to Wine source code.
This would not work on Macs as /etc/hosts is locked to admins only and would be a
problem to implement. 
4 Nov
4 Nov
6:29 a.m.
New subject: wininet: let automated testers force all DNS lookups to return localhost
On Friday 31 October 2008 16:11:58 Hans Leidekker wrote:
On Friday 31 October 2008 15:52:43 James Mckenzie
wrote:
That's true for Unix in general, but I think we require admin rights
already because the services need to bind ports below 1024 for example.
That's where the Samba style socket wrapper would help. The tricky part is
that this would have to be implemented in winsock, so it wouldn't necessarily
port to windows too well. On the other hand, binding to low ports isn't that
big of a problem on windows, and we require administrator privileges for the
tests anyway.
Cheers,
Kai
--
Kai Blin
WorldForge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/
--
Will code for cotton.
What
happened to your /etc/hosts proposal? It has the
advantage that we don't need changes to Wine source code.
This would not work on Macs as /etc/hosts is locked to admins only and
would be a problem to implement.
5659
days inactive
5663
days old
9 comments
6 participants
participants (6)
-
Dan Kegel -
Detlef Riekenberg -
Hans Leidekker -
Henri Verbeet -
James Mckenzie -
Kai Blin