Re: [7/8] d3dx9/tests: Add tests for compressed pixel formats support in D3DXLoadSurface functions.
10 May
2012
10 May
'12
9:16 a.m.
Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef Kucia:
+#define check_pixel_3bpp(lockrect, x, y, color) \
+ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] ==
...
Inline functions are generally prefered over macros where possible. I think it
is possible to pass a different line number to ok() to make the messages more
useful when they are called from a helper function, but I don't know how off
the top of my head. If you have to use a macro, please use capital letters.
10 May
10 May
9:23 a.m.
New subject: [7/8] d3dx9/tests: Add tests for compressed pixel formats support in D3DXLoadSurface functions.
On Thu, May 10, 2012 at 11:16 AM, Stefan Dösinger
<stefandoesinger(a)gmx.at> wrote:
Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef
Kucia:
I used this macro to be consistent with check_pixel_1bpp,
check_pixel_2bpp and check_pixel_4bpp macros.
+#define check_pixel_3bpp(lockrect, x, y, color)
\
+ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] ==
...
Inline functions are generally prefered over macros where possible. I think
it
is possible to pass a different line number to ok() to make the messages more
useful when they are called from a helper function, but I don't know how off
the top of my head. If you have to use a macro, please use capital letters.
4413
days inactive
4413
days old
1 comments
2 participants
participants (2)
-
Józef Kucia -
Stefan Dösinger