Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
29 Jun
2009
29 Jun
'09
7:49 a.m.
"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote:
+ if (*pcbProvName > INT_MAX)
+ *pcbProvName = INT_MAX;
In which way WideCharToMultiByte is broken? It always helps to provide
an explanation and if possible a test case.
--
Dmitry.
2 Jul
2 Jul
7:25 p.m.
New subject: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
On Mo, 2009-06-29 at 16:49 +0900, Dmitry Timoshkov wrote:
"Christoph von Wittich"
<Christoph(a)ApiViewer.de> wrote:
While working on the tests for shlwapi/SHUnicodeToAnsiCP,
i stumbled also over the broken handling of a negative dstlen in
WideCharToMultiByte.
We already have a test for this case, marked with todo_wine.
Fixing kernel32 was easy, so i send a Patch:
http://www.winehq.org/pipermail/wine-patches/2009-June/075165.html
Unfortunately, WideCharToMultiByte is called with a negative dstlen
from the Wine source.
(convert_PCREDENTIALW_to_PCREDENTIALA, but there might be more
locations.)
Christoph, are you working on this issue?
Otherwise i will take a look on the weekend, as I want to get
my tests for SHUnicodeToAnsiCP in the tree.
--
By by ... Detlef
+ if (*pcbProvName > INT_MAX)
+ *pcbProvName = INT_MAX;
In which way WideCharToMultiByte is broken? It always helps to provide
an explanation and if possible a test case.
5433
days inactive
5436
days old
1 comments
2 participants
participants (2)
-
Detlef Riekenberg -
Dmitry Timoshkov