1 Jun
2010
1 Jun
'10
9:38 a.m.
Joel Holdsworth <joel(a)airwebreathe.org.uk> writes:
+GpImage* LoadPNGResourceW(HINSTANCE hInst, LPCWSTR
lpName)
+{
You should be able to use an icon for this, there shouldn't be any need
to involve gdiplus.
--
Alexandre Julliard
julliard(a)winehq.org
1 Jun
1 Jun
5:50 p.m.
New subject: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
Are PNG icons supported? It didn't look like they were when I checked.
Also, sizes larger than 255px, are only partially supported in the
format. So any app, including wine would have legitimate reasons to
reject such a file.
On Tue, 2010-06-01 at 11:38 +0200, Alexandre Julliard wrote:
Joel Holdsworth <joel(a)airwebreathe.org.uk>
writes:
+GpImage* LoadPNGResourceW(HINSTANCE hInst,
LPCWSTR lpName)
+{
You should be able to use an icon for this, there shouldn't be any need
to involve gdiplus.
6:05 p.m.
New subject: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
Joel Holdsworth <joel(a)airwebreathe.org.uk> writes:
Are PNG icons supported? It didn't look like they
were when I checked.
Also, sizes larger than 255px, are only partially supported in the
format. So any app, including wine would have legitimate reasons to
reject such a file.
png icons are not supported but uncompressed ones should work
fine. If it really doesn't work you can always use a bitmap.
--
Alexandre Julliard
julliard(a)winehq.org
7:32 p.m.
New subject: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
On Tue, 2010-06-01 at 20:05 +0200, Alexandre Julliard wrote:
Joel Holdsworth <joel(a)airwebreathe.org.uk>
writes:
Are you sure? I really do think using PNGs is preferable. The PNG is
22.8kB, whereas a BMP would be 237.2kB - over 10x larger! If I use a
BMP, it will make the winecfg executable bloat up 25%.
By contrast importing GDI+ or WIC seems to me like a small price to pay.
Are PNG icons supported? It didn't look like
they were when I checked.
Also, sizes larger than 255px, are only partially supported in the
format. So any app, including wine would have legitimate reasons to
reject such a file.
png icons are not supported but uncompressed ones should work
fine. If it really doesn't work you can always use a bitmap.
8:39 p.m.
New subject: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
Joel Holdsworth <joel(a)airwebreathe.org.uk> writes:
Are you sure? I really do think using PNGs is
preferable. The PNG is
22.8kB, whereas a BMP would be 237.2kB - over 10x larger! If I use a
BMP, it will make the winecfg executable bloat up 25%.
By contrast importing GDI+ or WIC seems to me like a small price to pay.
We can add support for PNG icons after 1.2. Adding more dependencies to
winecfg is much more risky than a bloated icon.
--
Alexandre Julliard
julliard(a)winehq.org
9:17 p.m.
New subject: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
On Tue, 2010-06-01 at 22:39 +0200, Alexandre Julliard wrote:
Joel Holdsworth <joel(a)airwebreathe.org.uk>
writes:
Ok, that's cool. I'll try and get that sorted within a couple of days.
One other question; I got some feedback from Andre Herschel saying that
the patch failed to apply to some of the language rc files. I suspected
he ran into problems with varying character encodings. Did the patch
"[PATCH 4/4] winecfg: Cosmetic improvements to the about panel" apply
cleanly for you?
Are you sure? I really do think using PNGs is
preferable. The PNG is
22.8kB, whereas a BMP would be 237.2kB - over 10x larger! If I use a
BMP, it will make the winecfg executable bloat up 25%.
By contrast importing GDI+ or WIC seems to me like a small price to pay.
We can add support for PNG icons after 1.2. Adding more dependencies to
winecfg is much more risky than a bloated icon.
9:25 p.m.
New subject: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
Joel Holdsworth <joel(a)airwebreathe.org.uk> writes:
Ok, that's cool. I'll try and get that sorted
within a couple of days.
One other question; I got some feedback from Andre Herschel saying that
the patch failed to apply to some of the language rc files. I suspected
he ran into problems with varying character encodings. Did the patch
"[PATCH 4/4] winecfg: Cosmetic improvements to the about panel" apply
cleanly for you?
It looked OK to me. Patch 3 got spam filtered though. I've tried to fix
the spam rules, we'll see what happens when you resend...
--
Alexandre Julliard
julliard(a)winehq.org
5097
days inactive
5097
days old
6 comments
2 participants
participants (2)
-
Alexandre Julliard -
Joel Holdsworth