18 Jan
2016
18 Jan
'16
9:39 p.m.
On 18 January 2016 at 21:16, Józef Kucia <jkucia(a)codeweavers.com> wrote:
@@ -909,6 +919,7 @@ static void
shader_sm4_read_instruction(void *data, const DWORD **ptr, struct wi
ins->handler_idx = WINED3DSIH_TABLE_SIZE;
return;
}
+ priv->dst_param[i].modifiers |= instruction_dst_modifier;
This is
fine, although I wonder if you considered making saturation an
instruction modifier on the wined3d_shader_instruction side instead?
18 Jan
18 Jan
11:05 p.m.
New subject: [PATCH 6/7] wined3d: Recognize SM4 _sat instruction modifier.
On Mon, Jan 18, 2016 at 10:39 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
On 18 January 2016 at 21:16, Józef Kucia
<jkucia(a)codeweavers.com> wrote:
I've considered it but only briefly. It seems to me clearer to apply
the saturate modifier to destination parameters in SM4 frontend than
to extract the saturate modifier from a destination parameter in SM1
fronted (in order to apply it to a instruction).
@@ -909,6 +919,7 @@ static void
shader_sm4_read_instruction(void *data, const DWORD **ptr, struct wi
ins->handler_idx = WINED3DSIH_TABLE_SIZE;
return;
}
+ priv->dst_param[i].modifiers |= instruction_dst_modifier;
This is
fine, although I wonder if you considered making saturation an
instruction modifier on the wined3d_shader_instruction side instead?
3040
days inactive
3040
days old
1 comments
2 participants
participants (2)
-
Henri Verbeet -
Józef Kucia