Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5) - wine-devel

30 Jul 2010

Misha Koshelev &lt;misha680(a)gmail.com&gt; writes:

...
  +            for (i = 0; i < number_of_vertices;
i++)
 +            {
 +                ok(compare_vec3(vertices[i].position, mesh->vertices[i].position),
"Test %s, vertex position %d, result (%g, %g, %g), expected (%g, %g, %g)\n",
name, i, vertices[i].position.x, vertices[i].position.y, vertices[i].position.z,
mesh->vertices[i].position.x, mesh->vertices[i].position.y,
mesh->vertices[i].position.z);
 +                ok(compare_vec3(vertices[i].normal, mesh->vertices[i].normal),
"Test %s, vertex normal %d, result (%g, %g, %g), expected (%g, %g, %g)\n", name,
i, vertices[i].normal.x, vertices[i].normal.y, vertices[i].normal.z,
mesh->vertices[i].normal.x, mesh->vertices[i].normal.y,
mesh->vertices[i].normal.z); 
Please add some line breaks occasionally. 100 chars is a reasonable
limit, a bit more is tolerated, but 300 is too much.

...
  +    /* free lookup tables */
 +    free_sincos_table(&phi);
 +    free_sincos_table(&theta);
 +
 +    /* success */
 +    return TRUE; 
There's no need for that sort of comments, the purpose of that code is
obvious.

-- 
Alexandre Julliard
julliard(a)winehq.org