New subject: [PATCH 2/2] msxml3: implement preserveWhiteSpace property

30 Sep 2010

Adam Martinson &lt;amartinson(a)codeweavers.com&gt; writes:

...
  +#define WS_CHECK_IGNORED(doc) \
 +    ole_check(IXMLDOMDocument2_selectNodes(doc,
_bstr_("//*[local-name()='html']"), &list));\
 +    ole_check(IXMLDOMNodeList_get_item(list, 0, &node1));\
 +    ole_check(IXMLDOMNodeList_get_item(list, 1, &node2));\
 +    ole_check(IXMLDOMNodeList_reset(list));\
 +    expect_list_and_release(list, "E1.E4.E1.E2.D1 E2.E4.E1.E2.D1");\
 +    \
 +    ole_check(IXMLDOMNode_get_childNodes(node1, &list));\
 +    expect_list_and_release(list, "T1.E1.E4.E1.E2.D1 E2.E1.E4.E1.E2.D1
E3.E1.E4.E1.E2.D1 T4.E1.E4.E1.E2.D1 E5.E1.E4.E1.E2.D1");\
 +    IXMLDOMNode_Release(node1);\
 +    ole_check(IXMLDOMNode_get_childNodes(node2, &list));\
 +    expect_list_and_release(list, "T1.E2.E4.E1.E2.D1 E2.E2.E4.E1.E2.D1
T3.E2.E4.E1.E2.D1 E4.E2.E4.E1.E2.D1 T5.E2.E4.E1.E2.D1 E6.E2.E4.E1.E2.D1
T7.E2.E4.E1.E2.D1");\
 +    IXMLDOMNode_Release(node2) 
Please don't write such large macros. Put this in a helper function
instead.

-- 
Alexandre Julliard
julliard(a)winehq.org

Re: [PATCH 2/2] msxml3: implement preserveWhiteSpace property