29 Jun
2006
29 Jun
'06
5:26 p.m.
WineHQ wrote:
ChangeSet ID: 26125
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2006/06/29 11:07:20
Modified files:
. : appbrowse.php appsubmit.php appview.php
admin : adminAppDataQueue.php adminAppQueue.php
adminMaintainers.php
include : application.php bugs.php comment.php
monitor.php note.php screenshot.php
sidebar_login.php url.php util.php version.php
vote.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Clean up application and version classes. Move class related functions into the class
as static member functions
Patch: http://cvs.winehq.org/patch.py?id=26125
Old revision New revision Changes Path
1.13 1.14 +1 -1 appdb/appbrowse.php
1.43 1.44 +2 -2 appdb/appsubmit.php
1.82 1.83 +1 -1 appdb/appview.php
1.22 1.23 +6 -6 appdb/admin/adminAppDataQueue.php
1.57 1.58 +4 -4 appdb/admin/adminAppQueue.php
1.19 1.20 +3 -3 appdb/admin/adminMaintainers.php
1.50 1.51 +15 -53 appdb/include/application.php
1.10 1.11 +7 -5 appdb/include/bugs.php
1.21 1.22 +2 -2 appdb/include/comment.php
1.5 1.6 +10 -4 appdb/include/monitor.php
1.10 1.11 +4 -3 appdb/include/note.php
1.39 1.40 +7 -5 appdb/include/screenshot.php
1.13 1.14 +2 -2 appdb/include/sidebar_login.php
1.6 1.7 +7 -5 appdb/include/url.php
1.61 1.62 +18 -2 appdb/include/util.php
1.58 1.59 +47 -38 appdb/include/version.php
1.17 1.18 +2 -2 appdb/include/vote.php
This patch breaks the monitor notification emails.
--
Tony Lambregs
29 Jun
29 Jun
5:51 p.m.
New subject: appdb/ ./appbrowse.php ./appsubmit.php ./appvi ...
This patch breaks the monitor notification emails.
more specificly...
diff -u -p appdb/include/monitor.php:1.5
appdb/include/monitor.php:1.6
--- appdb/include/monitor.php:1.5 Thu Jun 29 17:43:08 2006
+++ appdb/include/monitor.php Thu Jun 29 17:43:08 2006
@@ -93,19 +93,25 @@ class Monitor {
function SendNotificationMail($sAction="add",$sMsg=null)
{
+ /* set $aAppName appropriately */
+ if(isset($this->iVersionId))
+ $sAppName = Application::lookup_name($oVersion->iAppId)."
".Version::lookup_name($this->iVersionId);
+ else
+ $sAppName = Application::lookup_name($oVersion->iAppId);
+
It looks like Application::lookup_name($oVersion->iAppId)returns "".
Also people can only monitor application versions they cannot
monitor application familys at this time.
--
Tony Lambregts
6:01 p.m.
New subject: appdb/ ./appbrowse.php ./appsubmit.php ./appvi ...
On Thursday 29 June 2006 1:51 pm, Tony Lambregts wrote:
Ahh yes. Using the version before the object exists. Fixing that.
Are they supposed to be able to monitor application familes? I'm confused as
to whether that is a bug or just how things are working.
Chris
This patch
breaks the monitor notification emails.
more specificly...
diff -u -p appdb/include/monitor.php:1.5
appdb/include/monitor.php:1.6
--- appdb/include/monitor.php:1.5 Thu Jun 29 17:43:08 2006
+++ appdb/include/monitor.php Thu Jun 29 17:43:08 2006
@@ -93,19 +93,25 @@ class Monitor {
function SendNotificationMail($sAction="add",$sMsg=null)
{
+ /* set $aAppName appropriately */
+ if(isset($this->iVersionId))
+ $sAppName = Application::lookup_name($oVersion->iAppId)."
".Version::lookup_name($this->iVersionId); + else
+ $sAppName = Application::lookup_name($oVersion->iAppId);
+
It looks like Application::lookup_name($oVersion->iAppId)returns "". Also
people can only monitor application versions they cannot monitor
application familys at this time.
6:19 p.m.
New subject: appdb/ ./appbrowse.php ./appsubmit.php ./appvi ...
Oh ok. If you wanted you could put that on the TODO page so we didn't forget
about it.
Chris
On Thursday 29 June 2006 2:18 pm, Tony Lambregts wrote:
Are they
supposed to be able to monitor application familes? I'm
confused as to whether that is a bug or just how things are working.
Chris
Not a bug just a missing feature. They never could.
--
Tony Lambregts
6534
days inactive
6534
days old
4 comments
2 participants
participants (2)
-
Chris Morgan -
Tony Lambregts