23 Nov
2012
23 Nov
'12
4:06 p.m.
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
Apparently this is how midl works
I'm not sure that's an improvement, it makes it harder to figure out the
actual value.
--
Alexandre Julliard
julliard(a)winehq.org
23 Nov
23 Nov
5:34 p.m.
New subject: [1/2] widl: Fix enum entries output based on previous entry value
On 11/23/2012 19:06, Alexandre Julliard wrote:
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
The reason I did that to match what midl does was that I got bunch of
compiler warnings trying to define
XmlError enum like that:
---
warning: this decimal constant is unsigned only in ISO C90
---
for each entry in enum that has a value calculated by widl. The reason
is that it always outputs it as decimal so you get:
0xc00cee00 for a first entry and
3222072833 for a next one.
It's probably possible to preserve hex format basing on last defined
value. Do you prefer this way?
Apparently this is how midl works
I'm
not sure that's an improvement, it makes it harder to figure out the
actual value.
4:54 p.m.
New subject: [1/2] widl: Fix enum entries output based on previous entry value
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
On 11/23/2012 19:06, Alexandre Julliard wrote:
Actually this should apply to all large enum constants. I put in a fix.
--
Alexandre Julliard
julliard(a)winehq.org
Nikolay Sivov <nsivov(a)codeweavers.com>
writes:
The reason I did that to match what midl does was that I got bunch of
compiler warnings trying to define
XmlError enum like that:
---
warning: this decimal constant is unsigned only in ISO C90
---
for each entry in enum that has a value calculated by widl. The reason
is that it always outputs it as decimal so you get:
0xc00cee00 for a first entry and
3222072833 for a next one.
It's probably possible to preserve hex format basing on last defined
value. Do you prefer this way? Apparently this is how midl works
I'm
not sure that's an improvement, it makes it harder to figure out the
actual value.
4195
days inactive
4195
days old
2 comments
2 participants
participants (2)
-
Alexandre Julliard -
Nikolay Sivov