Bugzilla admin, please disallow people to add/remove e-mail addresses
to/from bugs unless they've been given that right. Or at least have rights
to modify any aspect of the bug.
Thanks,
Vitaliy.
Gerald Pfeifer <gerald(a)pfeifer.com> writes:
> Not a patch I am particularily proud of, but the best way I found to get
> rid of
>
> listview.c:5043: warning: 'strW' might be used uninitialized in this function
>
> issued by GCC, and apart from the added cast it actually is simpler than
> the original.
It was done the way it is precisely to avoid the non-const cast, which
triggers a warning too.
--
Alexandre Julliard
julliard(a)winehq.org
interesting. Do you have a list of contributors and their signoff on
this license change?
Or is it just you two?
On Nov 24, 2007 12:36 PM, Alexander Nicolaysen Sørnes
<alex(a)thehandofagony.com> wrote:
> Change licence to AGPL
>
>
>
> Alexander N. Sørnes
>
>
>
>
Gerald Pfeifer <gerald(a)pfeifer.com> writes:
> One of the really uncontested ones, I think. ;-)
>
> ---------- Forwarded message ----------
> From: Gerald Pfeifer <gerald(a)pfeifer.com>
> To: <wine-patches(a)winehq.org>
> Date: Thu, 1 Nov 2007 16:10:03 +0100 (CET)
> Subject: Remove four useless checks in dlls/gdi32/enhmetafile.c
>
> The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so
> comparing them for >= 0 is a noop which always evaluates to true.
>
> Gerald
>
> ChangeLog:
> Remove four unnecessary comparisions of DWORD variables for >= 0.
Validating the record is not unnecessary, it just needs to be done
correctly by checking for wraparounds etc.
--
Alexandre Julliard
julliard(a)winehq.org
Hi Lei,
I think a new file for user dir look up in the shell32 is of no use.
Rather than we can add it to the xdg.c and xdg.h, as it contains the
generic xdg code for shell32.
Its like having all xdg specific code at one place.
This is my personal opinion about those patches.
Thanks,
VJ
Gerald Pfeifer <gerald(a)pfeifer.com> writes:
> Alexandre,
>
> I checked again and if we don't address this we'll get two new warnings
> issues in a default build with GCC 4.3. How does the patch below
> look?
Not good, it adds noise to the code for no good reason. Why would gcc
complain about that one?
--
Alexandre Julliard
julliard(a)winehq.org
I still do not see why it is not possible to have only one folder
dlls/d3dx9/ with the thirteen spec files inside. After all, the vast
majority of its code is repeated and it is the same system ctl3d,
ctl3d32 and ctl3dv2 use as the three specs are in dlls/ctl3d32
This is not creating subfolders in dlls/d3dx9 but just putting all spec
files in it.
Attention packagers: the default version of gcc on
many distros happens to generate Wine binaries which
make some copy protection schemes unhappy.
At the moment, gcc-3.3.x, gcc-3.4.x, and gcc-4.2.x are
known to work; gcc-4.0.x is known to not work.
Please check the compiler you use when building wine
packages and make sure it's one of the good ones.
To really check, find a retail copy of Photoshop CS or CS2
(not 7 or CS3) and install from cd-rom. If it aborts silently
near the end without offering to activate the product, you
have an unsupported compiler, and users of your packages
might run into trouble with apps protected with safedisc.
See http://bugs.winehq.org/show_bug.cgi?id=10273 for more info.
- Dan