Hi Rob,
Thanks for your work on jscript. Unfortunately fixing Valgrind on
jscript is not going to be easy. Most of your fixes are good, except
clear_global part and "jscript: Fix a circular reference caused by
object and function objects being able to have properties that are
objects and functions." patch. I've sent a test showing that Windows
doesn't do that. To fix it properly we need to implement a garbage
collector. I've designed it in the very early days of jscript, but I
never had time to implement it.
Thanks,
Jacek
On Thu, 2009-12-31 at 10:20 +0100, Warren Dumortier wrote:
> Thanks for all your work (is there some screenshot)?
> There's no doubt that the Tango icons are good, but would it be
> possible to easily make icon themes maybe, to have Oxygen icons for
> example? If i understand it's hardcoded, like on Windows, but making a
> theming feature is probably a lot of work right?
There will be some theming work coming later when someone finishes
implementing the uxtheme stuff. My icons are about getting a base theme
that works well. The point of Tango is that it shouldn't look to badly
out of place on Mac, KDE, Gnome or even Windows. That's a good starting
point, which we can build upon if someone can implement a wine theme
bridge.
On 12/29/2009 12:40 AM, Andrew Eikum wrote:
>
> Paul Vriens 'fixed' this test to ensure that two strings are not the
> same. Instead, the test should test that two strings _are_ the same,
> but I accidentally compared the wrong strings in the original version.
> ---
> dlls/hlink/tests/browse_ctx.c | 19 +++++++++++--------
> 1 files changed, 11 insertions(+), 8 deletions(-)
>
>
Hi Andrew,
Sorry about that. Thanks for really fixing it this time.
--
Cheers,
Paul.
Andrew Nguyen <arethusa26(a)gmail.com> writes:
> Some experimentation showed that the registry values that are read do
> control the CommonProgramFiles and ProgramFiles environment variables.
Is there any reason to not define it like the other environment
variables? Is there really an app that would change the CurrentVersion
key and expect the environment variable to change?
--
Alexandre Julliard
julliard(a)winehq.org
On 12/31/2009 05:47, Andrew Nguyen wrote:
> Some experimentation showed that the registry values that are read do
> control the CommonProgramFiles and ProgramFiles environment variables.
> ---
> dlls/kernel32/process.c | 27 ++++++++++++++++++++++++++-
> 1 files changed, 26 insertions(+), 1 deletions(-)
>
Hi, Andrew.
Alexandre recently removed 16bit headers inclusion, I don't think you
should revert this.
Peter Dons Tychen wrote:
> Why not place the test in the source tree along with all of
> the other tests. Of course this requires the tests to be run from a C
> based file
Yep. I should have a patch ready to submit tomorrow that
is a barebones batch file test driver written in C
suitable for use with winetestbot.
> It would however mean that one could add tests for all of the
> other command line utility programs much easier
> (not possible now at all).
Good point. The cmd tests can test not just cmd, but things
like expand and extrac32, too.
So, where should the tests live? I had been thinking programs/cmd/tests,
but maybe something like programs/tests would be better
given that it can test more than just cmd.
- Dan
I recently installed the bundled Wine for Mac OS X for someone and noticed
something that would be nice for "normal Wine." In the bundled Mac OS X
version a progress dialog* is displayed when prefix creation is occurring,
are there any plans to do something like this for Wine 1.2?
Erich Hoover
ehoover(a)mines.edu
*Note that this dialog doesn't show "real" progress, but at least lets the
user know something is happening.
I've noticed that Michael Stefuic (sp?) has removed quite a few WPARAM/LPARAM casts when calling SendMessage() and was wondering/inquiring if he was going do this to riched20/tests/editor.c since I noticed he put in a change for riched20.
Michael are you going to do so, or are you going to leave this to others?
Thank you.
James McKenzie