On 12/28/2009 22:18, David Quintana (gigaherz) wrote:
> Issue was caused by VK_F4 having the same exact code as a lowercase 's'.
> So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed
> the wrong piece of code which was meant to be ONLY for WM_KEYDOWN.
>
> Patch is attached.
>
>
>
>
Please resubmit without cpp style comments.
Am 27.12.2009 um 19:57 schrieb Henri Verbeet:
> +/* Context activation is done by the caller. */
> +static void context_apply_state(struct wined3d_context *context, IWineD3DDeviceImpl *device, enum ContextUsage usage)
The patch looks ok to me, but out of curiosity: Do you intend to make this function available to other wined3d code like context_acquire is, or is the main motivation of the patch to tidy up the context_acquire() function?
On 12/27/2009 01:27 AM, Jacek Caban wrote:
> ---
> dlls/wininet/tests/url.c | 77
> ++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 77 insertions(+), 0 deletions(-)
>
Hi Jacek,
Looks like these tests need at least IE7 to succeed.
Could you have a look?
--
Cheers,
Paul.
Hi,
I'm implementing DInput's SetActionFormat call. I need to add the DInput
Action Mapping Constants to Wine's dinput.h so I can map between the user
requested action and the DIJOFS_* Joystick Device Constants.
Is it OK to copy constant definitions from Microsoft's SDK? If not, can
somebody help me or give some pointers on how to figure them out?
This API call is needed at least for the Overlord game, which now works with
my XBox 360 gamepad, but all action mappings are currently wrong.
Thanks,
Hi,
Why this patch don't have been commited? There are mistakes?
I really want to make extrac32 better, but I don't know what to do if nobody
answer me.
--
Best regards,
Ilya Shpigor.
2009/12/24 Gerald Pfeifer <gerald(a)pfeifer.com>:
> On Mon, 21 Dec 2009, Henri Verbeet wrote:
>>> How shall we best tackle this?
>> At least for the wined3d ones, we might as well just add them to the
>> enum, the macros aren't strictly necessary.
>
> Done thusly. We just need to move WINEMAKEFOURCC to a local header,
> the rest of the cpp_quote can go and we lose a couple of dozen warning
> messages (rightfully) issued by GCC 4.5 snapshots.
>
I already sent pretty much the same patch,
http://source.winehq.org/git/wine.git/?a=commitdiff;h=3288911ae3e3cbd7124ed…
André Hentschel a écrit :
> -
> + if (*sym->current == 'A') sym->current++;
>
I don't understand how this would be necessary?
Are you sure it's needed ?
A+
--
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)
2009/12/27 Austin English <austinenglish(a)gmail.com>:
> See bug 18993. Original author is credited in patch ( Dorek Biglari ).
>
This doesn't look right from my understanding of the d3d9 depth bias
behaviour. Afaik D3DRS_SLOPESCALEDEPTHBIAS is a multiplication factor
for the maximum depth slope (i.e. difference in z-value over distance
for a polygon's vertices), just like in OpenGL. I attached an
alternative patch to the bug.