wine-devel April 2011

80 participants
185 discussions

by Greg Geldorp

Due to personal circumstances I won't be able to maintain the TestBot much longer. I'm looking for a volunteer to take over this responsibility. I can offer the hardware on which the bot runs for another 2 years or so. You'll get full access to the hardware. It helps if you have a bit of experience with VMware vSphere, but that's not absolutely required. Day-to-day operations have been running pretty smooth for the last couple of months, so the demand on your time won't be that great. There's the occasional account request that needs to be approved and that's pretty much it. Every now and then the VMs should be updated using Windows Update. The code itself seems to be reasonably stable. It's all Perl. If you're interested or would like more info, please let me know. Greg.

13 years, 1 month

Re: configure.ac: add a --without-prelink option

by Vitaliy Margolen

On 04/06/2011 07:53 PM, Austin English wrote: > Prelink is only available on Linux. It's not a reason to disable the warning. Without prelink, or other means to set load addresses of core dlls, compiled Wine won't be compatible with some programs. Mainly copy protection. Vitaliy.

13 years, 1 month

Re: user32: Add a test for activating a menu consisting from a single menu item using a hot key.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10366 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

13 years, 1 month

Translation commits for wine-1.2.3

by Michael Stefaniuc

Hello Alexandre, attached is the list of translation commits that can be cherry-picked for wine-1.2.3. Notes: - The cherry-picks for cryptui and wineconsole will need a manual conflict resolution as they depend on my janitorial commits. - The Arab and Hebrew translations are filtered out (support for mirroring is only in wine-1.3.x). bye michael

13 years, 1 month

Re: [PATCH] cmd: Added set /a (try 3, fixed tests and patch formatting) Some tests were written by Jack Kutilek

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10353 Your paranoid android. === W7PROX64 (64 bit) === batch.c:70: Test failed: CreateFile failed

13 years, 1 month

Re: ntdll: Remove more path trailing chars.

by Nikolay Sivov

On 4/2/2011 10:51, Vincent Pelletier wrote: > Add tests via FindFirstFileA. > Fixes bug 22635. > --- > dlls/kernel32/tests/file.c | 119 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/path.c | 8 +++- > 2 files changed, 126 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c > index 4e8136a..dae8eee 100644 > --- a/dlls/kernel32/tests/file.c > +++ b/dlls/kernel32/tests/file.c > @@ -2164,6 +2164,125 @@ static void test_FindFirstFileA(void) > err = GetLastError(); > ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 ); > ok ( err == ERROR_PATH_NOT_FOUND, "Bad Error number %d\n", err ); > + > + /* try FindFirstFileA on "test-dir" with forbidden chars */ > + CreateDirectoryA("test-dir", NULL); > + _lclose(_lcreat("test-file", 0)); > + > +#define FindFirstFileA_ok(value, caption, todo) { \ > + if(todo) { \ > + todo_wine ok(value, caption);\ > + } else { \ > + ok(value, caption);\ > + } \ > + } > + > +#define test_FindFirstFileA_with(x, y, todo) { \ > + handle = FindFirstFileA(x,&data);\ > + if (y) { \ > + FindFirstFileA_ok( \ > + handle != INVALID_HANDLE_VALUE, \ > + "FindFirstFile on "x" should succeed\n", \ > + todo);\ > + } else { \ > + FindFirstFileA_ok( \ > + handle == INVALID_HANDLE_VALUE, \ > + "FindFirstFile on "x" should fail\n", \ > + todo);\ > + } \ > + if (handle != INVALID_HANDLE_VALUE) \ > + ok( FindClose(handle) == TRUE, "Failed to close handle "x"\n"); \ > + } > + > + /* Disallowed chars being ignored: */ > + test_FindFirstFileA_with("test-dir/.", 1, 0); > + test_FindFirstFileA_with("test-dir\\.", 1, 0); > + test_FindFirstFileA_with("test-dir<.", 1, 0); > + test_FindFirstFileA_with("test-dir< ", 1, 0); > + test_FindFirstFileA_with("test-dir>.", 1, 0); > + test_FindFirstFileA_with("test-dir> ", 1, 0); > + test_FindFirstFileA_with("test-dir\".", 1, 0); > + test_FindFirstFileA_with("test-dir\" ", 1, 0); > + test_FindFirstFileA_with("test-dir/>", 1, 0); > + test_FindFirstFileA_with("test-dir/<", 1, 0); > + test_FindFirstFileA_with("test-dir/\"", 1, 0); > + test_FindFirstFileA_with("test-dir<>", 1, 0); > + test_FindFirstFileA_with("test-dir<<", 1, 0); > + test_FindFirstFileA_with("test-dir<\"", 1, 0); > + test_FindFirstFileA_with("test-dir>>", 1, 0); > + test_FindFirstFileA_with("test-dir><", 1, 0); > + test_FindFirstFileA_with("test-dir>\"", 1, 0); > + test_FindFirstFileA_with("test-dir\">", 1, 0); > + test_FindFirstFileA_with("test-dir\"<", 1, 0); > + test_FindFirstFileA_with("test-dir\"\"", 1, 0); > + test_FindFirstFileA_with("test-dir\\<", 1, 0); > + test_FindFirstFileA_with("test-dir\\>", 1, 0); > + test_FindFirstFileA_with("test-dir\\\"", 1, 0); > + /* But space prevents forward& back slashes from being stripped */ > + test_FindFirstFileA_with("test-dir<", 0, 1); > + test_FindFirstFileA_with("test-dir/ ", 0, 0); > + test_FindFirstFileA_with("test-dir/ .", 0, 0); > + test_FindFirstFileA_with("test-dir/. ", 0, 1); > + test_FindFirstFileA_with("test-dir\\ ", 0, 0); > + test_FindFirstFileA_with("test-dir\\ .", 0, 0); > + test_FindFirstFileA_with("test-dir\\. ", 0, 1); > + test_FindFirstFileA_with("test-dir/. ", 0, 1); > + test_FindFirstFileA_with("test-dir\\. ", 0, 1); > + /* But forward& back slashes are not tolerated on a file */ > + test_FindFirstFileA_with("test-file/>", 0, 1); > + test_FindFirstFileA_with("test-file/<", 0, 1); > + test_FindFirstFileA_with("test-file/\"", 0, 1); > + test_FindFirstFileA_with("test-file<>", 1, 0); > + test_FindFirstFileA_with("test-file<<", 1, 0); > + test_FindFirstFileA_with("test-file<\"", 1, 0); > + test_FindFirstFileA_with("test-file>>", 1, 0); > + test_FindFirstFileA_with("test-file><", 1, 0); > + test_FindFirstFileA_with("test-file>\"", 1, 0); > + test_FindFirstFileA_with("test-file\">", 1, 0); > + test_FindFirstFileA_with("test-file\"<", 1, 0); > + test_FindFirstFileA_with("test-file\"\"", 1, 0); > + test_FindFirstFileA_with("test-file\\<", 0, 1); > + test_FindFirstFileA_with("test-file\\>", 0, 1); > + test_FindFirstFileA_with("test-file\\\"", 0, 1); > + /* Even when many */ > + test_FindFirstFileA_with("test-dir\"\"\"\"\"", 1, 0); > + test_FindFirstFileA_with("test-dir<<<><><>\"\"\"\"<<<>", 1, 0); > + /* But only in the end of path */ > + test_FindFirstFileA_with("test-/>dir", 0, 0); > + test_FindFirstFileA_with("/>test-dir", 0, 0); > + test_FindFirstFileA_with(">test-dir", 0, 0); > + test_FindFirstFileA_with(">>test-dir", 0, 0); > + test_FindFirstFileA_with(">test->dir", 0, 0); > + test_FindFirstFileA_with("><test->dir", 0, 0); > + test_FindFirstFileA_with("<test->dir", 0, 0); > + test_FindFirstFileA_with("<\"test->dir", 0, 0); > + > + /* Slash after ignored chars is not ignored: */ > + test_FindFirstFileA_with("test-dir//", 0, 0); > + test_FindFirstFileA_with("test-dir</", 0, 0); > + test_FindFirstFileA_with("test-dir>/", 0, 0); > + test_FindFirstFileA_with("test-dir\"/", 0, 0); > + test_FindFirstFileA_with("test-dir\\", 0, 0); > + test_FindFirstFileA_with("test-dir\\\\", 0, 0); > + test_FindFirstFileA_with("test-dir\\/", 0, 0); > + test_FindFirstFileA_with("test-dir/\\", 0, 0); > + > + /* Disalowed chars being preserved: */ > + test_FindFirstFileA_with("test-dir/:", 0, 0); > + test_FindFirstFileA_with("test-dir/|", 0, 0); > + > + /* Slashes converted to backslashes */ > + test_FindFirstFileA_with("test-dir/", 0, 0); > + test_FindFirstFileA_with("./test-dir", 1, 0); > + test_FindFirstFileA_with("./test-dir/", 0, 0); > + test_FindFirstFileA_with("test-dir\\", 0, 0); > + test_FindFirstFileA_with(".\\test-dir", 1, 0); > + test_FindFirstFileA_with(".\\test-dir\\", 0, 0); > + > +#undef test_FindFirstFileA_with > +#undef FindFirstFileA_ok > + DeleteFileA("test-file"); > + RemoveDirectoryA("test-dir"); > } Please use table for test data and put your macro body in a loop.

13 years, 1 month

Re: cmd: Added set /a (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10349 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

13 years, 1 month

Sorry about the duplicate patches.

by Joel Teichroeb

When trying to submit my first patch I did not do it correctly, and on http://source.winehq.org/patches/ it shows up 5 times. The correct patch is http://www.winehq.org/pipermail/wine-patches/2011-April/100677.html Thanks for your patience. Joel Teichroeb

13 years, 1 month

Re: gdi32/tests: Start of a framework for writing dib driver tests.

by Huw Davies

On Tue, Apr 05, 2011 at 03:31:23PM +0100, Huw Davies wrote: > > Try2. Using the A_SHA functions to generate the hashes. Although somewhat neater than the first version it doesn't work on nt4/win2k as they don't export these functions. So we're better off using the original. Huw.

13 years, 1 month

Re: gdi32/tests: Start of a framework for writing dib driver tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10338 Your paranoid android. === WNT4WSSP6 (32 bit dib) === Timeout === W2KPROSP4 (32 bit dib) === Timeout

13 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2011