On Thursday 28 April 2011 00:34:24 Matteo Bruni wrote:
> This should fix http://bugs.winehq.org/show_bug.cgi?id=26780
I see this patch was committed, I think I should really read wine-patches more
often.
I added the RCP 0 handling because StarCraft 2 needed it. Did you test this
with SC2? Specifically, the Water was black without proper handling of rcp 0
On 04/27/2011 01:14 AM, Nikolay Sivov wrote:
> Remove practically unused parameters from test functions
>
So how is global variable any better then local variable passed as function
parameter?
IMHO this is s wrong thing to do - to move everything as global variables
just to move it back whenever need arises.
Vitaliy.
On Thu, Apr 28, 2011 at 14:52, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote:
> ---
> Now using atexit function to cleanup up the output file on errors, and
> parsing errors are signaled using a boolean error variable.
>
> diff --git a/include/rmxftmpl.x b/include/rmxftmpl.x
> new file mode 100644
> index 0000000..e7144b0
> --- /dev/null
> +++ b/include/rmxftmpl.x
> @@ -0,0 +1,268 @@
> +xof 0302txt 0064
> +// Copyright (C) 2011 Dylan Smith
> +//
> +// This library is free software; you can redistribute it and/or
> +// modify it under the terms of the GNU Lesser General Public
> +// License as published by the Free Software Foundation; either
> +// version 2.1 of the License, or (at your option) any later version.
> +//
> +// This library is distributed in the hope that it will be useful,
> +// but WITHOUT ANY WARRANTY; without even the implied warranty of
> +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +// Lesser General Public License for more details.
> +//
> +// You should have received a copy of the GNU Lesser General Public
> +// License along with this library; if not, write to the Free Software
> +// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
Looks like some C99 comments slipped in.
--
-Austin
Hello,
why did you use C++ comments ?
A+
David
+xof 0302txt 0064
> +// Copyright (C) 2011 Dylan Smith
> +//
> +// This library is free software; you can redistribute it and/or
>
>
>
>
On 4/28/2011 13:25, Hwang YunSong(???) wrote:
> updated
> #: hhctrl.rc:73
> -#, fuzzy
> -msgctxt "table of contents"
> +msgctxt "????????+??? ?????????"
> msgid "&Home"
> -msgstr "???"
> +msgstr "???(&H)"
msgctxt is not a thing to translate as I understand it. It's an
additional identifier to distinguish multiple translation variations.
I'm not so convinced there's value in this, considering there are no
known applications depending on this. Stefan thinks it's useful
anyway. If you do want to spend the effort to make this go in, note
that this affects ddraw and d3d8 as well, not just d3d9. The test
should probably just have a loop in depth_buffer_test() itself, or
even write a test specific for this purpose. The wined3d part might as
well handle the state as a BOOL, considering WINED3DZB_USEW isn't
handled all that different from WINED3DZB_TRUE, except for the FIXME.
Hi,
Damjan Jovanovic wrote:
>In the meanwhile I've found another problem: mciavi32 always deadlocks
>when MCI_WAIT is not set:[...] ShowWindow()
Looks like bug #21060 and the others
http://bugs.winehq.org/show_bug.cgi?id=21060#c2
- bug #12908, bug #15669, bug #18363 involving ShowWindow;
- bug #14785, bug #21060 involving EnterCriticalSection.
But perhaps there's only a single issue.
It would be nice if somebody who knows about windows and their
messages would look at these.
Regards,
Jörg Höhle
Damjan,
can you recommend any downloadable 16bit app that stresses the MCI?
It's good that you noticed that RECT16 and RECT do not have the same size (whack!).
Yet I'm surprised that you left MCI_WINDOW untouched. I believe that
the apps that use MCI_WHERE/PUT etc. (i.e. MCIAVI) are likely to use
MCI_WINDOW as well to set the window handle.
Does no FIXME appear in your console?
http://source.winehq.org/source/dlls/mmsystem.dll16/mci16.c#L182
The comment there is obsolete. dwFlags is available and could be used like I did in
db0df4c067fd6b701905aaef735c4729fca9d73f
Regards,
Jörg Höhle