29 Jul
2011
29 Jul
'11
2:38 p.m.
Henri Verbeet wrote:
On 29 July 2011 09:46,
<Joerg-Cyril.Hoehle(a)t-systems.com> wrote:
As always a categorical
"It depends!". git send-email is not for everybody.
If you're new to (Wine) development or you do a lot of janitorial work I
would actually recommend to *avoid* git send-email. See it as an
opportunity to look again at your patch when you manually submit it.
Like a last line of defense to spare you from embarrassment. Git is
powerful and it is kinda cool that you can efficiently submit the 7th
version of a 20 patch series on the same day! But that doesn't means it
is a great idea to actually do it; you'll only get yourself graylisted
by Alexandre.
bye
michael
P.S.: "You" refers to the interested reader and not to Henri.
these fixes all trivial errors I mentioned
recently but one, plus a few ones I discovered since then.
These need to be separate patches, of course. I'd also encourage
everyone to just use git send-email for sending patches.