Hi Hans,
On 07/23/2010 09:42 AM, Hans Leidekker wrote:
> + /* full UI, no ResolveSource action */
> + r = MsiInstallProductA(msifile, NULL);
> + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r);
Right about here I get a popup, waiting for 'OK' to be pushed, on
Win95/98/Me that says "Test 14 failed". That does explain some of the
timeouts we see on test.winehq.org for those platforms as of this patch.
--
Cheers,
Paul.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4065
Your paranoid android.
=== W98SE (32 bit gameexplorer) ===
gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)
=== WNT4WSSP6 (32 bit gameexplorer) ===
gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)
=== W2KPROSP4 (32 bit gameexplorer) ===
gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)
=== WXPPROSP3 (32 bit gameexplorer) ===
gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)
=== W2K3R2SESP2 (32 bit gameexplorer) ===
gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)
=== W2K8SE (32 bit gameexplorer) ===
gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4063
Your paranoid android.
=== W98SE (32 bit gameexplorer) ===
gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)
=== WNT4WSSP6 (32 bit gameexplorer) ===
gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)
=== W2KPROSP4 (32 bit gameexplorer) ===
gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)
=== WXPPROSP3 (32 bit gameexplorer) ===
gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)
=== W2K3R2SESP2 (32 bit gameexplorer) ===
gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)
=== W2K8SE (32 bit gameexplorer) ===
gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)
Maarten,
@@ -331,16 +331,14 @@ static DWORD MCIQTZ_mciSeek(UINT wDevID, DWORD dwFlags, LPMCI_SEEK_PARMS lpParms
- MCIQTZ_mciStop(wDevID, MCI_WAIT, NULL);
is there a reason why you remove that?
The MCI devices (mciwave, sequencer, avivideo, quartz with .avi, quartz with
midi, quartz with .wav) all stop playing when seeking.
How do you handle that in mciqtz?
Is it delegated to the individual renderers? I don't see where.
IIRC, I believe once found one exception but I can't remember where that was
(perhaps mcicda? mcicda is quite a different beast, as it continues playing even
after the application closes the device and exits, unlike the other MCI devices).
Regards,
Jörg Höhle
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4059
Your paranoid android.
=== W98SE (32 bit ordinal) ===
ordinal.c:616: Test failed: GetShellSecurityDescriptor should fail, got 0096F808
=== WVISTAADM (32 bit ordinal) ===
No test summary line found
=== W7PRO (32 bit ordinal) ===
ordinal.c:1783: Test failed: got 13
ordinal.c:1789: Test failed: got 25
ordinal.c:1804: Test failed: got 10
ordinal.c:1817: Test failed: got 13
ordinal.c:1825: Test failed: got 13
ordinal.c:1847: Test failed: got 25
ordinal.c:1855: Test failed: got 37, length 38
ordinal.c:1866: Test failed: got 40
ordinal.c:1877: Test failed: got 23
ordinal.c:1888: Test failed: got 26
=== W7PROX64 (32 bit ordinal) ===
ordinal.c:1789: Test failed: got 24
ordinal.c:1839: Test failed: got 24
ordinal.c:1847: Test failed: got 24
ordinal.c:1855: Test failed: got 33, length 34
ordinal.c:1866: Test failed: got 36
=== W7PROX64 (64 bit ordinal) ===
ordinal.c:1783: Test failed: got 10
ordinal.c:1804: Test failed: got 7
ordinal.c:1817: Test failed: got 10
ordinal.c:1825: Test failed: got 10
ordinal.c:1855: Test failed: got 33, length 34
ordinal.c:1866: Test failed: got 36
ordinal.c:1877: Test failed: got 20
ordinal.c:1888: Test failed: got 23
Misha Koshelev <misha680(a)gmail.com> writes:
> + for (i = 0; i < number_of_vertices; i++)
> + {
> + ok(compare_vec3(vertices[i].position, mesh->vertices[i].position), "Test %s, vertex position %d, result (%g, %g, %g), expected (%g, %g, %g)\n", name, i, vertices[i].position.x, vertices[i].position.y, vertices[i].position.z, mesh->vertices[i].position.x, mesh->vertices[i].position.y, mesh->vertices[i].position.z);
> + ok(compare_vec3(vertices[i].normal, mesh->vertices[i].normal), "Test %s, vertex normal %d, result (%g, %g, %g), expected (%g, %g, %g)\n", name, i, vertices[i].normal.x, vertices[i].normal.y, vertices[i].normal.z, mesh->vertices[i].normal.x, mesh->vertices[i].normal.y, mesh->vertices[i].normal.z);
Please add some line breaks occasionally. 100 chars is a reasonable
limit, a bit more is tolerated, but 300 is too much.
> + /* free lookup tables */
> + free_sincos_table(&phi);
> + free_sincos_table(&theta);
> +
> + /* success */
> + return TRUE;
There's no need for that sort of comments, the purpose of that code is
obvious.
--
Alexandre Julliard
julliard(a)winehq.org