Huw Davies <huw(a)codeweavers.com> wrote:
> case DirectColor:
> X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL;
> - case GrayScale:
> + case GrayScale: /* fall through */
case DirectColor:
X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL;
/* fall through */
case GrayScale:
would be more clear IMHO. Right now it's not obvious to which case statement
'fall through' belongs to.
Same for other changes.
--
Dmitry.
For every wine version, static checkers (like coverity) detect cases
where a switch case automatically falls-through to the next case.
Shouldn't be there a rule that such cases are always marked with a
"fall-through comment"?
With the possible exception of case with no statement? like 'case FOO:
case BAR: do_something();...'?
This would probably help IMHO, especially when people refactor old code.
Frédéric
André Hentschel <nerv(a)dawncrow.de> wrote:
> diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c
> index c670731..f66d858 100644
> --- a/dlls/ntdll/tests/info.c
> +++ b/dlls/ntdll/tests/info.c
> @@ -1336,7 +1336,8 @@ static void test_mapprotection(void)
> status = pNtQueryVirtualMemory( GetCurrentProcess(), addr, MemoryBasicInformation, &info, sizeof(info), &retlen );
> ok( status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %08x\n", status);
> ok( retlen == sizeof(info), "Expected STATUS_SUCCESS, got %08x\n", status);
> - ok(info.Protect == PAGE_READWRITE, "addr.Protect is not PAGE_READWRITE, but 0x%x\n", info.Protect);
> + ok(info.Protect == PAGE_READWRITE || broken(info.Protect == PAGE_NOCACHE | PAGE_READWRITE /* win8 */),
> + "addr.Protect is not PAGE_READWRITE, but 0x%x\n", info.Protect);
This is not broken. You should either mask PAGE_NOCACHE out before
the comparison, or accept both values.
Same applies to other your patches.
--
Dmitry.
"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes:
> This particular patch implements SetNamedSecurityInfoW by layering it
> on top of SetSecurityInfo, which permits the creation of tests for
> part 2 (GetNamedSecurityInfoW). This version has been updated to fix
> a bad return value and includes a test indicating the correct value
> (ERROR_FILE_NOT_FOUND).
That doesn't mean you can hardcode that specific error.
--
Alexandre Julliard
julliard(a)winehq.org
Henri wrote:
>+ /* Recent (304.64, possibly earlier) versions of the nvidia driver only
>+ * report a DFP's native mode through RandR 1.2 / 1.3. Standard DMT modes
>+ * are only listed through RandR 1.0 / 1.1. This is completely useless,
>+ * but NVIDIA considers this a feature, so it's unlikely to change
Do you happen to have a link to discussion about this, or an nvidia bug number?
Thanks!
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
> Apparently this is how midl works
I'm not sure that's an improvement, it makes it harder to figure out the
actual value.
--
Alexandre Julliard
julliard(a)winehq.org
Does QueryCapability really initialize the decoder? Can you get a
frame out of it? I guess it never occurred to me to try.
I was OK with this for the other implementations because I figured
it'd be easy enough to invalidate the decoder after successfully
calling Initialize, if that turned out to be a problem.
Hi all,
Firefox 17 was released lately, meaning that Firefox 18 goes to beta
channel and it's the next target for out Gecko package update. I've
uploaded new Gecko builds to SourceForge [1]. To test them, you need
recent Wine Git version with the attached patch. As usually, grab the
build from SourceForge, put it in the right place [2] and run patched
Wine. All help with testing is appreciated!
Thanks,
Jacek
[1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.9-beta1/
[2] http://wiki.winehq.org/Gecko